third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js - Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaseline Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html ('K') | « third_party/WebKit/Source/devtools/front_end/network/RequestResponseView.js ('k') | third_party/WebKit/Source/devtools/front_end/resources/FileContentView.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

index 36aa1aa589f280d3fd8462993cca9329509080c4..189668a6f411092ce22233adbb98afbb43734303 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js

@@ -117,7 +117,7 @@ WebInspector.ResourceWebSocketFrameView.prototype = {

{

var selectedNode = /** @type {!WebInspector.ResourceWebSocketFrameNode} */ (event.target.selectedNode);

var contentProvider = selectedNode.contentProvider();

- contentProvider.requestContent(content => {

+ contentProvider.requestContent().then(content => {

var parsedJSON = content ? WebInspector.JSONView.parseJSON(content) : null;

var view = parsedJSON ? new WebInspector.JSONView(parsedJSON) : new WebInspector.ResourceSourceFrame(contentProvider);

this._splitWidget.setSidebarWidget(view);