Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js

Issue 1609973002: DevTools: promisify ContentProvider.requestContent and all its clients. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaseline Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js b/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
index f743434ded65b0a2e3bcab98d23cbec59023b0dd..db9eebe8510448458815e35fad5aa180159f7cfb 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ContentProviders.js
@@ -61,11 +61,14 @@ WebInspector.CompilerSourceMappingContentProvider.prototype = {
/**
* @override
- * @param {function(?string)} callback
+ * @return {!Promise<?string>}
*/
- requestContent: function(callback)
+ requestContent: function()
{
+ var callback;
pfeldman 2016/01/20 19:23:51 cache promise
lushnikov 2016/01/20 23:35:58 This patch is big enough and does its job. The cac
+ var promise = new Promise(fulfill => callback = fulfill);
WebInspector.multitargetNetworkManager.loadResource(this._sourceURL, contentLoaded.bind(this));
+ return promise;
/**
* @param {number} statusCode
@@ -94,7 +97,7 @@ WebInspector.CompilerSourceMappingContentProvider.prototype = {
*/
searchInContent: function(query, caseSensitive, isRegex, callback)
{
- this.requestContent(contentLoaded);
+ this.requestContent().then(contentLoaded);
/**
* @param {?string} content

Powered by Google App Engine
This is Rietveld 408576698