Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1609943003: Make platform/heap to use USING_FAST_MALLOC. (Closed)

Created:
4 years, 11 months ago by tasak
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews-api_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, blink-reviews, kinuko+watch, kouhei+heap_chromium.org, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make platform/heap to use USING_FAST_MALLOC. BUG=562431 Committed: https://crrev.com/d7ecf41cea5cadad69535740e07bb6887283fc32 Cr-Commit-Position: refs/heads/master@{#371469}

Patch Set 1 #

Patch Set 2 : Fixed compile error #

Total comments: 6

Patch Set 3 : Rebased #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -19 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/WebCacheMemoryDumpProvider.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCacheMemoryDumpProvider.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCInterruptor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/BlinkGCMemoryDumpProvider.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/GCInfo.h View 8 chunks +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GCInfo.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/GCTaskRunner.h View 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 10 chunks +20 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 6 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapAllocator.h View 16 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapLinkedStack.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 2 3 6 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArray.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTerminatedArrayBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/MarkingVisitorImpl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.h View 4 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PagePool.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PersistentNode.h View 5 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/SafePoint.h View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/StackFrameDepth.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 7 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadingTraits.h View 7 chunks +29 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/TraceTraits.h View 15 chunks +24 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Visitor.h View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
tasak
Would you review this CL?
4 years, 11 months ago (2016-01-20 10:41:43 UTC) #3
haraken
https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h File third_party/WebKit/Source/platform/heap/HeapPage.h (right): https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h#newcode584 third_party/WebKit/Source/platform/heap/HeapPage.h:584: size_t size = sizeof(HeapDoesNotContainCache) + sizeof(Address) * HeapDoesNotContainCache::numberOfEntries; Can ...
4 years, 11 months ago (2016-01-20 10:52:27 UTC) #4
tasak
Thank you for review. https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h File third_party/WebKit/Source/platform/heap/HeapPage.h (right): https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h#newcode584 third_party/WebKit/Source/platform/heap/HeapPage.h:584: size_t size = sizeof(HeapDoesNotContainCache) + ...
4 years, 11 months ago (2016-01-21 04:37:46 UTC) #5
haraken
https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h File third_party/WebKit/Source/platform/heap/HeapPage.h (right): https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h#newcode584 third_party/WebKit/Source/platform/heap/HeapPage.h:584: size_t size = sizeof(HeapDoesNotContainCache) + sizeof(Address) * HeapDoesNotContainCache::numberOfEntries; On ...
4 years, 11 months ago (2016-01-21 04:52:57 UTC) #6
tasak
https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h File third_party/WebKit/Source/platform/heap/HeapPage.h (right): https://codereview.chromium.org/1609943003/diff/20001/third_party/WebKit/Source/platform/heap/HeapPage.h#newcode584 third_party/WebKit/Source/platform/heap/HeapPage.h:584: size_t size = sizeof(HeapDoesNotContainCache) + sizeof(Address) * HeapDoesNotContainCache::numberOfEntries; On ...
4 years, 11 months ago (2016-01-26 02:54:46 UTC) #7
haraken
LGTM
4 years, 11 months ago (2016-01-26 03:32:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1609943003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1609943003/60001
4 years, 11 months ago (2016-01-26 05:28:40 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-26 06:41:19 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 06:42:41 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/d7ecf41cea5cadad69535740e07bb6887283fc32
Cr-Commit-Position: refs/heads/master@{#371469}

Powered by Google App Engine
This is Rietveld 408576698