Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1619443002: Move Partitions::initialize() before Platform::initialize(). (Closed)

Created:
4 years, 11 months ago by tasak
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kinuko+watch, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Partitions::initialize() before Platform::initialize(). BUG= Committed: https://crrev.com/e851311c07d93803331eeb24106dfd46100ba4b4 Cr-Commit-Position: refs/heads/master@{#370658}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move Partitions::shutdown out of WTF::shutdown #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTF.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/testing/RunAllTests.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
tasak
PTAL?
4 years, 11 months ago (2016-01-21 04:38:03 UTC) #2
haraken
LGTM with a comment. https://codereview.chromium.org/1619443002/diff/1/third_party/WebKit/Source/wtf/WTF.cpp File third_party/WebKit/Source/wtf/WTF.cpp (right): https://codereview.chromium.org/1619443002/diff/1/third_party/WebKit/Source/wtf/WTF.cpp#newcode62 third_party/WebKit/Source/wtf/WTF.cpp:62: Partitions::shutdown(); Can we move Partitions::shutdown() ...
4 years, 11 months ago (2016-01-21 04:54:25 UTC) #3
tasak
Thank you for review. https://codereview.chromium.org/1619443002/diff/1/third_party/WebKit/Source/wtf/WTF.cpp File third_party/WebKit/Source/wtf/WTF.cpp (right): https://codereview.chromium.org/1619443002/diff/1/third_party/WebKit/Source/wtf/WTF.cpp#newcode62 third_party/WebKit/Source/wtf/WTF.cpp:62: Partitions::shutdown(); On 2016/01/21 04:54:25, haraken ...
4 years, 11 months ago (2016-01-21 09:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1619443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1619443002/20001
4 years, 11 months ago (2016-01-21 09:02:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 10:14:41 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:15:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e851311c07d93803331eeb24106dfd46100ba4b4
Cr-Commit-Position: refs/heads/master@{#370658}

Powered by Google App Engine
This is Rietveld 408576698