Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: src/IceTargetLoweringARM32.cpp

Issue 1609753002: Subzero. ARM32. Fixes infinite loop during address mode formation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringARM32.cpp
diff --git a/src/IceTargetLoweringARM32.cpp b/src/IceTargetLoweringARM32.cpp
index 6ca28ed04449dddbdef8e7082b53c559d8a8008c..d9d9afad195adf92eefef2d88814746d4e669660 100644
--- a/src/IceTargetLoweringARM32.cpp
+++ b/src/IceTargetLoweringARM32.cpp
@@ -4892,10 +4892,12 @@ bool matchAssign(const VariablesMetadata *VMetadata, Variable **Var,
return false;
Operand *SrcOp = VarAssign->getSrc(0);
+ bool Optimized = false;
if (auto *SrcVar = llvm::dyn_cast<Variable>(SrcOp)) {
if (!VMetadata->isMultiDef(SrcVar) ||
// TODO: ensure SrcVar stays single-BB
false) {
+ Optimized = true;
*Var = SrcVar;
} else if (auto *Const = llvm::dyn_cast<ConstantInteger32>(SrcOp)) {
int32_t MoreOffset = Const->getValue();
@@ -4904,13 +4906,15 @@ bool matchAssign(const VariablesMetadata *VMetadata, Variable **Var,
return false;
*Var = nullptr;
*Offset += NewOffset;
+ Optimized = true;
}
+ }
+ if (Optimized) {
*Reason = VarAssign;
- return true;
}
- return false;
+ return Optimized;
}
bool isAddOrSub(const Inst *Inst, InstArithmetic::OpKind *Kind) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698