Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: third_party/qcms/BUILD.gn

Issue 1609643003: Disable qcms_tests target for Android or iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo and use disable_qcms else logic for qcms target Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/qcms/qcms.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/qcms/BUILD.gn
diff --git a/third_party/qcms/BUILD.gn b/third_party/qcms/BUILD.gn
index e6041e7c325db1fab94828e1b5c58ac09dbb4868..6b4cf46491519dd1783e45c170b6b1f42766eb37 100644
--- a/third_party/qcms/BUILD.gn
+++ b/third_party/qcms/BUILD.gn
@@ -6,8 +6,11 @@ config("qcms_config") {
include_dirs = [ "src" ]
}
+# Do not build QCMS on Android or iOS. (See http://crbug.com/577155)
+disable_qcms = is_android || is_ios
+
source_set("qcms") {
- if (is_android || is_ios) {
+ if (disable_qcms) {
sources = [
"src/empty.c",
]
@@ -45,7 +48,7 @@ source_set("qcms") {
}
}
-if (current_cpu == "x86" || current_cpu == "x64") {
+if (!disable_qcms && (current_cpu == "x86" || current_cpu == "x64")) {
executable("qcms_tests") {
defines = [ "SSE2_ENABLE" ]
sources = [
« no previous file with comments | « no previous file | third_party/qcms/qcms.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698