Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/qcms/qcms.gyp

Issue 1609643003: Disable qcms_tests target for Android or iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo and use disable_qcms else logic for qcms target Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/qcms/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/qcms/qcms.gyp
diff --git a/third_party/qcms/qcms.gyp b/third_party/qcms/qcms.gyp
index 4b54db5c3e2db22075e26776dc183760e6eeb121..c18ffe20bb8490370fcba605d34d79626b5a5848 100644
--- a/third_party/qcms/qcms.gyp
+++ b/third_party/qcms/qcms.gyp
@@ -3,6 +3,16 @@
# found in the LICENSE file.
{
+ 'variables': {
+ 'conditions': [
+ # Do not build QCMS on Android or iOS. (See http://crbug.com/577155)
+ ['OS == "android" or OS == "ios"', {
+ 'disable_qcms%': 1,
+ }, {
+ 'disable_qcms%': 0,
+ }],
+ ],
+ },
'targets': [
{
'target_name': 'qcms',
@@ -20,12 +30,11 @@
},
'conditions': [
- ['OS=="android" or OS=="ios"', {
+ ['disable_qcms == 1', {
'sources': [
'src/empty.c',
],
- }],
- ['OS!="android" and OS!="ios"', {
+ }, { # disable_qcms == 0
'sources': [
'src/chain.c',
'src/chain.h',
@@ -58,20 +67,17 @@
}],
],
},
- {
- 'target_name': 'qcms_tests',
- 'product_name': 'qcms_tests',
- 'type': 'executable',
- 'conditions': [
- ['target_arch=="ia32" or target_arch=="x64"', {
+ ],
+ 'conditions': [
+ ['disable_qcms == 0', {
+ 'targets': [
+ {
+ 'target_name': 'qcms_tests',
+ 'product_name': 'qcms_tests',
+ 'type': 'executable',
'defines': [
'SSE2_ENABLE',
],
- 'sources': [
- 'src/tests/qcms_test_tetra_clut_rgba.c',
- 'src/tests/qcms_test_main.c',
- 'src/tests/qcms_test_munsell.c',
- ],
'dependencies': [
'qcms',
],
@@ -81,10 +87,17 @@
'-lm',
],
}],
+ ['target_arch=="ia32" or target_arch=="x64"', {
+ 'sources': [
+ 'src/tests/qcms_test_tetra_clut_rgba.c',
+ 'src/tests/qcms_test_main.c',
+ 'src/tests/qcms_test_munsell.c',
+ ],
+ }],
],
- }],
+ },
],
- },
+ }],
],
}
« no previous file with comments | « third_party/qcms/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698