Disable qcms_tests target for Android or iOS.

Disable qcms_tests target for Android or iOS.

BUG=578960, 577155
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.

Committed: https://crrev.com/86aca8d13499c9d80fe2ca457ecb0fe644aef7df
Cr-Commit-Position: refs/heads/master@{#370394}

[haltonhuo, 2016-01-19 07:05:39]

halton.huo@intel.com changed reviewers:
+ noel@chromium.org

[haltonhuo, 2016-01-19 07:05:40]

noel, PTAL

[Noel Gordon, 2016-01-19 09:03:52]

Seems fine. Radu or Robert should review.

[Noel Gordon, 2016-01-19 09:04:19]

Description was changed from

==========
[GN] Disable qcms_tests for Android.

qcms_tests does not exist for arm Android build at all, so does for the
x86/x64 Android build.

BUG=578960
TESTS=Check third_party/qcms:qcms_tests not available for Android build.
==========

to

==========
[GN] Disable qcms_tests for Android.

qcms_tests does not exist for arm Android build at all, so does for the
x86/x64 Android build.

BUG=578960
TESTS=Check third_party/qcms:qcms_tests not available for Android build.
==========

[Noel Gordon, 2016-01-19 09:04:19]

noel@chromium.org changed reviewers:
+ radu.velea@intel.com, robert.bradford@intel.com

[Noel Gordon, 2016-01-19 09:06:27]

Description was changed from

==========
[GN] Disable qcms_tests for Android.

qcms_tests does not exist for arm Android build at all, so does for the
x86/x64 Android build.

BUG=578960
TESTS=Check third_party/qcms:qcms_tests not available for Android build.
==========

to

==========
[GN] Disable qcms_tests for Android

qcms_tests does not exist for arm Android build at all, so does for the
x86/x64 Android build.

BUG=578960
TESTS=Check third_party/qcms:qcms_tests not available for Android build.
==========

[radu.velea, 2016-01-20 10:00:27]

On 2016/01/19 09:03:52, noel gordon wrote:
> Seems fine. Radu or Robert should review.

Shouldn't we change qcms.gyp as well?

[haltonhuo, 2016-01-20 10:16:53]

On 2016/01/20 10:00:27, radu.velea wrote:
> On 2016/01/19 09:03:52, noel gordon wrote:
> > Seems fine. Radu or Robert should review.
> 
> Shouldn't we change qcms.gyp as well?

Good question. 

qcms target is empty target on Android and iOS. patch set1 remove qcms_tests
target totally. Should do same thing as qcms?

[Noel Gordon, 2016-01-20 10:43:44]

qcms_tests is are target we build locally: the bots don't need to build it
at all.

On 20 January 2016 at 21:16, <halton.huo@intel.com> wrote:

> On 2016/01/20 10:00:27, radu.velea wrote:
>
>> On 2016/01/19 09:03:52, noel gordon wrote:
>> > Seems fine. Radu or Robert should review.
>>
>
> Shouldn't we change qcms.gyp as well?
>>
>
> Good question.
>
> qcms target is empty target on Android and iOS. patch set1 remove
> qcms_tests
> target totally. Should do same thing as qcms?
>
> https://codereview.chromium.org/1609643003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Noel Gordon, 2016-01-20 10:46:28]

On 2016/01/20 10:43:44, noel gordon wrote:
> qcms_tests is are target we build locally: the bots don't need to build it
> at all.

Well "is a target" we build locally.  We should modify the gn and gyp such that
the bots mostly don't build it.  I worry about the "all" target if some bots
build that target though.

[haltonhuo, 2016-01-20 11:02:47]

On 2016/01/20 10:46:28, noel gordon wrote:
> On 2016/01/20 10:43:44, noel gordon wrote:
> > qcms_tests is are target we build locally: the bots don't need to build it
> > at all.
> 
> Well "is a target" we build locally.  We should modify the gn and gyp such
that
> the bots mostly don't build it.  I worry about the "all" target if some bots
> build that target though.

I'm making a new patch set to make the qcms_tests build qcms_test_main_empty.c
file, WDYT?

Or you need simply remove qcms_tests target totally on Android or iOS?

[radu.velea, 2016-01-20 11:04:57]

On 2016/01/20 11:02:47, haltonhuo wrote:
> On 2016/01/20 10:46:28, noel gordon wrote:
> > On 2016/01/20 10:43:44, noel gordon wrote:
> > > qcms_tests is are target we build locally: the bots don't need to build it
> > > at all.
> > 
> > Well "is a target" we build locally.  We should modify the gn and gyp such
> that
> > the bots mostly don't build it.  I worry about the "all" target if some bots
> > build that target though.
> 
> I'm making a new patch set to make the qcms_tests build qcms_test_main_empty.c
> file, WDYT?
> 
> Or you need simply remove qcms_tests target totally on Android or iOS?

I don't see any reason to have the tests built on Android or iOS.

[haltonhuo, 2016-01-20 11:36:33]

Description was changed from

==========
[GN] Disable qcms_tests for Android

qcms_tests does not exist for arm Android build at all, so does for the
x86/x64 Android build.

BUG=578960
TESTS=Check third_party/qcms:qcms_tests not available for Android build.
==========

to

==========
Disable qcms_tests target for Android or iOS.
    
BUG=578960
TESTS=qcms_tests target not available on Android build, both GYP and GN.
==========

[haltonhuo, 2016-01-20 11:38:38]

patch set2 upload with GYP changes

[radu.velea, 2016-01-20 11:46:36]

https://codereview.chromium.org/1609643003/diff/20001/third_party/qcms/qcms.gyp
File third_party/qcms/qcms.gyp (right):

https://codereview.chromium.org/1609643003/diff/20001/third_party/qcms/qcms.g...
third_party/qcms/qcms.gyp:38: ['OS!="android" and OS!="ios"', {
I think maybe an else condition would work here as well?

[haltonhuo, 2016-01-20 12:00:00]

Description was changed from

==========
Disable qcms_tests target for Android or iOS.
    
BUG=578960
TESTS=qcms_tests target not available on Android build, both GYP and GN.
==========

to

==========
Disable qcms_tests target for Android or iOS.
    
BUG=578960
TESTS=qcms_tests target not available on Android build, both GYP and GN.
      build and run qcms_tsts on Linux build.
==========

[haltonhuo, 2016-01-20 12:00:31]

On 2016/01/20 11:46:36, radu.velea wrote:
>
https://codereview.chromium.org/1609643003/diff/20001/third_party/qcms/qcms.gyp
> File third_party/qcms/qcms.gyp (right):
> 
>
https://codereview.chromium.org/1609643003/diff/20001/third_party/qcms/qcms.g...
> third_party/qcms/qcms.gyp:38: ['OS!="android" and OS!="ios"', {
> I think maybe an else condition would work here as well?

Fixed in set3. PTAL

[robert.bradford, 2016-01-20 12:08:20]

The CQ bit was checked by robert.bradford@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 12:08:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609643003/40001

[commit-bot: I haz the power, 2016-01-20 13:18:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 13:18:45]

Dry run: This issue passed the CQ dry run.

[radu.velea, 2016-01-20 13:34:38]

On 2016/01/20 13:18:45, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm

[Noel Gordon, 2016-01-20 13:36:57]

rs+LGTM

[Noel Gordon, 2016-01-20 14:04:46]

Description was changed from

==========
Disable qcms_tests target for Android or iOS.
    
BUG=578960
TESTS=qcms_tests target not available on Android build, both GYP and GN.
      build and run qcms_tsts on Linux build.
==========

to

==========
Disable qcms_tests target for Android or iOS.
    
BUG=578960
TESTS=qcms_tests target not available on Android build, both GYP and GN. Build
and run qcms_tests target on Linux build.
==========

[Noel Gordon, 2016-01-20 14:06:08]

Description was changed from

==========
Disable qcms_tests target for Android or iOS.
    
BUG=578960
TESTS=qcms_tests target not available on Android build, both GYP and GN. Build
and run qcms_tests target on Linux build.
==========

to

==========
Disable qcms_tests target for Android or iOS.

BUG=578960
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.
==========

[Noel Gordon, 2016-01-20 14:07:41]

Robert should also approve before submit.

[Noel Gordon, 2016-01-20 14:08:47]

Description was changed from

==========
Disable qcms_tests target for Android or iOS.

BUG=578960
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.
==========

to

==========
Disable qcms_tests target for Android or iOS.

BUG=578960,577155
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.
==========

[robert.bradford, 2016-01-20 15:09:32]

lgtm+cq i'll keep an eye on the waterfalls.

[robert.bradford, 2016-01-20 15:09:39]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2016-01-20 15:10:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609643003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609643003/40001

[commit-bot: I haz the power, 2016-01-20 15:15:37]

Description was changed from

==========
Disable qcms_tests target for Android or iOS.

BUG=578960,577155
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.
==========

to

==========
Disable qcms_tests target for Android or iOS.

BUG=578960,577155
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.
==========

[commit-bot: I haz the power, 2016-01-20 15:15:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-20 15:16:35]

Description was changed from

==========
Disable qcms_tests target for Android or iOS.

BUG=578960,577155
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.
==========

to

==========
Disable qcms_tests target for Android or iOS.

BUG=578960,577155
TESTS=qcms_tests target not available on Android build, both
GYP and GN. Build and run qcms_tests target on Linux build.

Committed: https://crrev.com/86aca8d13499c9d80fe2ca457ecb0fe644aef7df
Cr-Commit-Position: refs/heads/master@{#370394}
==========

[commit-bot: I haz the power, 2016-01-20 15:16:36]

Patchset 3 (id:??) landed as
https://crrev.com/86aca8d13499c9d80fe2ca457ecb0fe644aef7df
Cr-Commit-Position: refs/heads/master@{#370394}