Extract GlobalValueNumberer and helper classes from hydrogen.cc and move to hydrogen-gvn.cc.

Extract GlobalValueNumberer and helper classes from hydrogen.cc and move to hydrogen-gvn.cc.

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14824

[Sven Panne, 2013-05-27 11:41:23]

https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h#newcode1949
src/hydrogen.h:1949: class SparseSet {
I think it makes sense to move this to a separate file, too, or at least put it
somewhere else, there is nothing hydrogen-specific here. In general, I would
like to see some general data structure subdirectory, but perhaps that's just
me... :-)

https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h#newcode1988
src/hydrogen.h:1988: class HGlobalValueNumberer BASE_EMBEDDED {
To be consistent, this should really live in a new hydrogen-gvn.h file.

[titzer, 2013-05-27 12:22:09]

https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h#newcode1949
src/hydrogen.h:1949: class SparseSet {
On 2013/05/27 11:41:23, Sven Panne wrote:
> I think it makes sense to move this to a separate file, too, or at least put
it
> somewhere else, there is nothing hydrogen-specific here. In general, I would
> like to see some general data structure subdirectory, but perhaps that's just
> me... :-)

As discussed in-person, we can move this datastructure when we begin to refactor
the includes for other datastructures as well.

https://codereview.chromium.org/16095004/diff/1/src/hydrogen.h#newcode1988
src/hydrogen.h:1988: class HGlobalValueNumberer BASE_EMBEDDED {
On 2013/05/27 11:41:23, Sven Panne wrote:
> To be consistent, this should really live in a new hydrogen-gvn.h file.

Done.

[Sven Panne, 2013-05-27 12:24:17]

LGTM (mostly rubber-stamped)

[titzer, 2013-05-27 12:45:55]

Committed patchset #2 manually as r14824 (presubmit successful).