third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp - Issue 1609343002: Move hasPendingActivity from ActiveDOMObject to ScriptWrappable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

Issue 1609343002: Move hasPendingActivity from ActiveDOMObject to ScriptWrappable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('K') | « third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp ('k') | third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

diff --git a/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp b/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

index 48a20138f9e1a11ca8c6419495a73734a3c81d9b..ebdb27e1f7e157ad4b6d4c9d128b245ee396e683 100644

--- a/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

+++ b/third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp

@@ -28,6 +28,7 @@

#include "core/workers/WorkerMessagingProxy.h"

+#include "bindings/core/v8/V8GCController.h"

#include "core/dom/CrossThreadTask.h"

#include "core/dom/Document.h"

#include "core/events/ErrorEvent.h"

@@ -66,7 +67,7 @@ void processMessageOnWorkerGlobalScope(PassRefPtr<SerializedScriptValue> message

WorkerGlobalScope* globalScope = toWorkerGlobalScope(scriptContext);

MessagePortArray* ports = MessagePort::entanglePorts(*scriptContext, channels);

globalScope->dispatchEvent(MessageEvent::create(ports, message));

- workerObjectProxy->confirmMessageFromWorkerObject(scriptContext->hasPendingActivity());

+ workerObjectProxy->confirmMessageFromWorkerObject(V8GCController::hasPendingActivity(scriptContext));

}

} // namespace