third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp - Issue 1609343002: Move hasPendingActivity from ActiveDOMObject to ScriptWrappable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

Issue 1609343002: Move hasPendingActivity from ActiveDOMObject to ScriptWrappable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('K') | « third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h ('k') | third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

index 840b2fc1d58853fa78b2eb5a575e41f85faee1af..bf8cbb4d26f0f57946a8b78879c116ed59359fc6 100644

--- a/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

+++ b/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp

@@ -104,18 +104,6 @@ unsigned ContextLifecycleNotifier::activeDOMObjectCount() const

return activeDOMObjects;

}

-bool ContextLifecycleNotifier::hasPendingActivity() const

- for (ContextLifecycleObserver* observer : m_observers) {

- if (observer->observerType() != ContextLifecycleObserver::ActiveDOMObjectType)

- continue;

- ActiveDOMObject* activeDOMObject = static_cast<ActiveDOMObject*>(observer);

- if (activeDOMObject->hasPendingActivity())

- return true;

- }

- return false;

#if ENABLE(ASSERT)

bool ContextLifecycleNotifier::contains(ActiveDOMObject* object) const

{