Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 16093017: Automatically generate constructor attributes on WorkerContext (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, kinuko, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, haraken, Nate Chapin, lgombos
Visibility:
Public.

Description

Automatically generate constructor attributes on WorkerContext Add [GlobalContext=WindowOnly|WorkerOnly|WindowAndWorker] IDL extended attribute to indicate to the bindings generator on which global context the constructor attribute should be generated for interfaces without [NoInterfaceObject]: - WindowOnly: only on the global Window object (default if ommitted) - WorkerOnly: only on the worker context - WindowAndWorker: On both the global Window object and the worker context This covers all the current use cases. The bindings generator now automatically generates the Constructor attributes on the WorkerContext for non-callback interfaces which do not have the [NoInterfaceObject] extended attribute but have [GlobalContext=WorkerOnly|WindowAndWorker] extended attribute. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151777

Patch Set 1 #

Patch Set 2 : Fix bindings tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -39 lines) Patch
M Source/bindings/derived_sources.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/bindings/scripts/IDLAttributes.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/scripts/preprocess_idls.py View 4 chunks +22 lines, -10 lines 0 comments Download
M Source/core/dom/MessageChannel.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MessageEvent.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fileapi/Blob.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fileapi/FileReader.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/URL.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/ArrayBuffer.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/DataView.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Float32Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Float64Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Int16Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Int32Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Int8Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Uint16Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Uint32Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Uint8Array.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/Uint8ClampedArray.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerContext.idl View 1 chunk +1 line, -25 lines 0 comments Download
M Source/core/workers/WorkerLocation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/Scripts/webkitpy/bindings/main.py View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-04 11:43:48 UTC) #1
haraken
LGTM. Great patch.
7 years, 6 months ago (2013-06-04 11:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16093017/5001
7 years, 6 months ago (2013-06-04 17:57:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=11433
7 years, 6 months ago (2013-06-04 18:54:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16093017/5001
7 years, 6 months ago (2013-06-04 18:56:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=11450
7 years, 6 months ago (2013-06-04 19:48:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16093017/5001
7 years, 6 months ago (2013-06-04 20:05:25 UTC) #7
commit-bot: I haz the power
Change committed as 151777
7 years, 6 months ago (2013-06-04 20:56:56 UTC) #8
do-not-use
7 years, 6 months ago (2013-06-05 06:49:50 UTC) #9
Message was sent while issue was closed. 
On 2013/06/04 20:56:56, I haz the power (commit-bot) wrote:
> Change committed as 151777

Added [GlobalContext] documentation to the Blink IDL wiki:
https://sites.google.com/a/chromium.org/dev/blink/webidl?pli=1#TOC-GlobalCont...

Powered by Google App Engine
This is Rietveld 408576698