Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4152)

Unified Diff: Tools/Scripts/webkitpy/bindings/main.py

Issue 16093017: Automatically generate constructor attributes on WorkerContext (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix bindings tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XMLHttpRequest.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/bindings/main.py
diff --git a/Tools/Scripts/webkitpy/bindings/main.py b/Tools/Scripts/webkitpy/bindings/main.py
index 48536c2aef16fe19011aa46eab3d5a311fd5fa5e..bb76f5bca414493c62ef5c55d7f54823815197d6 100644
--- a/Tools/Scripts/webkitpy/bindings/main.py
+++ b/Tools/Scripts/webkitpy/bindings/main.py
@@ -60,7 +60,7 @@ class BindingsTests:
exit_code = e.exit_code
return exit_code
- def generate_supplemental_dependency(self, input_directory, supplemental_dependency_file, window_constructors_file):
+ def generate_supplemental_dependency(self, input_directory, supplemental_dependency_file, window_constructors_file, workercontext_constructors_file):
idl_files_list = tempfile.mkstemp()
for input_file in os.listdir(input_directory):
(name, extension) = os.path.splitext(input_file)
@@ -74,6 +74,7 @@ class BindingsTests:
'--idl-files-list', idl_files_list[1],
'--supplemental-dependency-file', supplemental_dependency_file,
'--window-constructors-file', window_constructors_file,
+ '--workercontext-constructors-file', workercontext_constructors_file,
'--write-file-only-if-changed', '0']
exit_code = 0
@@ -149,7 +150,8 @@ class BindingsTests:
input_directory = os.path.join('bindings', 'tests', 'idls')
supplemental_dependency_file = tempfile.mkstemp()[1]
window_constructors_file = tempfile.mkstemp()[1]
- if self.generate_supplemental_dependency(input_directory, supplemental_dependency_file, window_constructors_file):
+ workercontext_constructors_file = tempfile.mkstemp()[1]
+ if self.generate_supplemental_dependency(input_directory, supplemental_dependency_file, window_constructors_file, workercontext_constructors_file):
print 'Failed to generate a supplemental dependency file.'
os.remove(supplemental_dependency_file)
return -1
« no previous file with comments | « Source/core/xml/XMLHttpRequest.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698