Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2574)

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 1609193002: [UseZoomForDSF] Alwatys use DIP coordinates in pepper plugin (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/pepper_plugin_instance_impl.h
diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h
index cb9b60cc0286674f31746369b61ac793e98b9750..0ab2151b8bbd041565c4999c227eca3ffb708803 100644
--- a/content/renderer/pepper/pepper_plugin_instance_impl.h
+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h
@@ -91,6 +91,7 @@ class TextureLayer;
namespace gfx {
class Range;
+class Rect;
}
namespace ppapi {
@@ -370,6 +371,10 @@ class CONTENT_EXPORT PepperPluginInstanceImpl
document_loader_ = loader;
}
+ // Converts the PP_Rect between DIP and Viewport.
+ void ConvertRectToDIP(PP_Rect* rect) const;
+ void ConvertDIPToViewport(gfx::Rect* rect) const;
bbudge 2016/01/21 00:34:52 Is there a reason these are public?
oshima 2016/01/21 01:12:07 Nope, thank you for the catch. Moved to private/bo
+
ContentDecryptorDelegate* GetContentDecryptorDelegate();
// PluginInstance implementation
@@ -922,6 +927,8 @@ class CONTENT_EXPORT PepperPluginInstanceImpl
bool initialized_;
+ float viewport_to_dip_scale_;
bbudge 2016/01/21 00:34:51 nit: Maybe it would be better to group this with o
oshima 2016/01/21 01:12:07 Done.
+
// We use a weak ptr factory for scheduling DidChangeView events so that we
// can tell whether updates are pending and consolidate them. When there's
// already a weak ptr pending (HasWeakPtrs is true), code should update the

Powered by Google App Engine
This is Rietveld 408576698