[UseZoomForDSF] Alwatys use DIP coordinates in pepper plugin

content/renderer/pepper/pepper_plugin_instance_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
 #define CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 73 matching lines @@
 struct WebURLError;
 struct WebPrintParams;
 }
 
 namespace cc {
 class TextureLayer;
 }
 
 namespace gfx {
 class Range;
+class Rect;
 }
 
 namespace ppapi {
 class Resource;
 struct InputEventData;
 struct PPP_Instance_Combined;
 class ScopedPPVar;
 }
 
 namespace content {
@@ skipping 259 matching lines @@
   // case is non-NULL as long as the corresponding loader resource is alive.
   // This pointer is non-owning, so the loader must use set_document_loader to
   // clear itself when it is destroyed.
   blink::WebURLLoaderClient* document_loader() const {
     return document_loader_;
   }
   void set_document_loader(blink::WebURLLoaderClient* loader) {
     document_loader_ = loader;
   }
 
+  // Converts the PP_Rect between DIP and Viewport.
+  void ConvertRectToDIP(PP_Rect* rect) const;
+  void ConvertDIPToViewport(gfx::Rect* rect) const;

[bbudge, 2016/01/21 00:34:52]

Is there a reason these are public?

[oshima, 2016/01/21 01:12:07]

Nope, thank you for the catch. Moved to private/bottom.

+
   ContentDecryptorDelegate* GetContentDecryptorDelegate();
 
   // PluginInstance implementation
   RenderView* GetRenderView() override;
   blink::WebPluginContainer* GetContainer() override;
   v8::Isolate* GetIsolate() const override;
   ppapi::VarTracker* GetVarTracker() override;
   const GURL& GetPluginURL() override;
   base::FilePath GetModulePath() override;
   PP_Resource CreateImage(gfx::ImageSkia* source_image, float scale) override;
@@ skipping 532 matching lines @@
 
   scoped_ptr<MouseLockDispatcher::LockTarget> lock_target_;
 
   bool is_deleted_;
 
   // The text that is currently selected in the plugin.
   base::string16 selected_text_;
 
   bool initialized_;
 
+  float viewport_to_dip_scale_;

[bbudge, 2016/01/21 00:34:51]

nit: Maybe it would be better to group this with other viewport related fields
(view_data_).

[oshima, 2016/01/21 01:12:07]

Done.

+
   // We use a weak ptr factory for scheduling DidChangeView events so that we
   // can tell whether updates are pending and consolidate them. When there's
   // already a weak ptr pending (HasWeakPtrs is true), code should update the
   // view_data_ but not send updates. This also allows us to cancel scheduled
   // view change events.
   base::WeakPtrFactory<PepperPluginInstanceImpl> view_change_weak_ptr_factory_;
   base::WeakPtrFactory<PepperPluginInstanceImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperPluginInstanceImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PEPPER_PEPPER_PLUGIN_INSTANCE_IMPL_H_