Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Issue 1608943003: [css-grid] Fix positioned items in grids with implicit tracks (Closed)

Created:
4 years, 11 months ago by Manuel Rego
Modified:
4 years, 11 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Fix positioned items in grids with implicit tracks We were detecting wrongly the first and last explicit grid lines during the layout of positioned grid items. We have to consider that the grid can have implicit tracks created previously by regular grid items. BUG=273898 TEST=fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html Committed: https://crrev.com/63585e1ac3b452938a34df46855342d90005ed46 Cr-Commit-Position: refs/heads/master@{#370375}

Patch Set 1 #

Patch Set 2 : Fixed test as we need explicit lines #

Messages

Total messages: 8 (3 generated)
Manuel Rego
Simple fix for positioned items.
4 years, 11 months ago (2016-01-19 18:14:23 UTC) #2
svillar
lgtm
4 years, 11 months ago (2016-01-20 10:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608943003/20001
4 years, 11 months ago (2016-01-20 10:19:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-20 13:22:01 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 13:22:51 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63585e1ac3b452938a34df46855342d90005ed46
Cr-Commit-Position: refs/heads/master@{#370375}

Powered by Google App Engine
This is Rietveld 408576698