Switch RenderFrameHost pending deletion list to use scoped_ptr.

Switch RenderFrameHost pending deletion list to use scoped_ptr.

BUG=556939
Committed: https://crrev.com/3c81b4cef71386d223046b4b602d9bbd529b50ae
Cr-Commit-Position: refs/heads/master@{#370535}

[dcheng, 2016-01-20 08:55:19]

dcheng@chromium.org changed reviewers:
+ creis@chromium.org

[dcheng, 2016-01-20 08:55:20]

More minor cleanup.

https://codereview.chromium.org/1608743004/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.h (right):

https://codereview.chromium.org/1608743004/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.h:758: using
RFHPendingDeleteList = std::list<scoped_ptr<RenderFrameHostImpl>>;
Note: I could use std::set, but that still doesn't give sub-linear lookup: a
scoped_ptr (and std::unique_ptr) is not directly comparable against a raw
pointer.

One solution is to use a std::map<T*, scoped_ptr<T>>, if you feel it's worth
doing.

[Charlie Reis, 2016-01-20 22:03:24]

LGTM

https://codereview.chromium.org/1608743004/diff/1/content/browser/frame_host/...
File content/browser/frame_host/render_frame_host_manager.h (right):

https://codereview.chromium.org/1608743004/diff/1/content/browser/frame_host/...
content/browser/frame_host/render_frame_host_manager.h:758: using
RFHPendingDeleteList = std::list<scoped_ptr<RenderFrameHostImpl>>;
On 2016/01/20 08:55:20, dcheng wrote:
> Note: I could use std::set, but that still doesn't give sub-linear lookup: a
> scoped_ptr (and std::unique_ptr) is not directly comparable against a raw
> pointer.
> 
> One solution is to use a std::map<T*, scoped_ptr<T>>, if you feel it's worth
> doing.

No, this seems fine.

[dcheng, 2016-01-20 22:05:28]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-01-20 22:05:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608743004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608743004/1

[commit-bot: I haz the power, 2016-01-20 23:51:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-20 23:52:17]

Description was changed from

==========
Switch RenderFrameHost pending deletion list to use scoped_ptr.

BUG=556939
==========

to

==========
Switch RenderFrameHost pending deletion list to use scoped_ptr.

BUG=556939

Committed: https://crrev.com/3c81b4cef71386d223046b4b602d9bbd529b50ae
Cr-Commit-Position: refs/heads/master@{#370535}
==========

[commit-bot: I haz the power, 2016-01-20 23:52:18]

Patchset 1 (id:??) landed as
https://crrev.com/3c81b4cef71386d223046b4b602d9bbd529b50ae
Cr-Commit-Position: refs/heads/master@{#370535}