Switch RenderFrameHost pending deletion list to use scoped_ptr.

content/browser/frame_host/render_frame_host_manager.h

Index: content/browser/frame_host/render_frame_host_manager.h
diff --git a/content/browser/frame_host/render_frame_host_manager.h b/content/browser/frame_host/render_frame_host_manager.h
index c84167220307a1839b86edaac60259ca06e451d9..e208aa4c9838313cb287f466e8374cdb48ca03eb 100644
--- a/content/browser/frame_host/render_frame_host_manager.h
+++ b/content/browser/frame_host/render_frame_host_manager.h
@@ -754,10 +754,8 @@ class CONTENT_EXPORT RenderFrameHostManager
   base::ScopedPtrHashMap<int32_t, scoped_ptr<RenderFrameProxyHost>>
       proxy_hosts_;
 
-  // A list of RenderFrameHosts waiting to shut down after swapping out.  We use
-  // a linked list since we expect frequent deletes and no indexed access, and
-  // because sets don't appear to support linked_ptrs.
-  typedef std::list<linked_ptr<RenderFrameHostImpl> > RFHPendingDeleteList;
+  // A list of RenderFrameHosts waiting to shut down after swapping out.
+  using RFHPendingDeleteList = std::list<scoped_ptr<RenderFrameHostImpl>>;

[dcheng, 2016/01/20 08:55:20]

Note: I could use std::set, but that still doesn't give sub-linear lookup: a
scoped_ptr (and std::unique_ptr) is not directly comparable against a raw
pointer.

One solution is to use a std::map<T*, scoped_ptr<T>>, if you feel it's worth
doing.

[Charlie Reis, 2016/01/20 22:03:23]

No, this seems fine.

   RFHPendingDeleteList pending_delete_hosts_;
 
   // The intersitial page currently shown if any, not own by this class