Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

BUG=579196
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298385

[jam, 2016-01-19 20:52:09]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org, sheyang@chromium.org

[jam, 2016-01-19 20:52:10]

I did retrain the recipe expectations, but I'm still getting this error and I'm
not sure how to fix it?

AssertionError: Unconsumed test data for steps: ['test r1.gl_tests (r1) on
Windows-7-SP1'], (exception None)

----------------------------------------------------------------------
Trained 1947 tests in 13.090s (ran 1947 tests)

Coverage Report                                                                 
                     Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------------------------------------------------
scripts/slave/recipes/findit/chromium/test                                      
                        73      1    99%   151
-----------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                           
                     16152      1    99%

[jam, 2016-01-20 00:55:10]

ok stgao kindly fixed the findit recipe test. 

please review. also sheyang, can you reboot the master after this lands? I can
file a ticket after this goes through the CQ.

[scottmg, 2016-01-20 00:58:04]

lgtm

mseaborn mentioned on the chromium-dev thread that these might be the only
coverage for a NaCl config? Or is that a separate nacl waterfall issue?

[Dirk Pranke, 2016-01-20 00:59:44]

Description was changed from

==========
Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

BUG=579196
==========

to

==========
Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

BUG=579196
==========

[Dirk Pranke, 2016-01-20 01:01:09]

The blink team's rebaseline-o-matic downloads files from the XP bot; we should
turn off XP support
in that code before landing this and removing the bots completely. Maybe check
w/ ojan@ or
tansell@?

[sheyang, 2016-01-20 01:06:11]

lgtm

[jam, 2016-01-20 01:06:35]

jam@chromium.org changed reviewers:
+ ojan@chromium.org

[jam, 2016-01-20 01:07:00]

On 2016/01/20 01:01:09, Dirk Pranke (slow) wrote:
> The blink team's rebaseline-o-matic downloads files from the XP bot; we should
> turn off XP support
> in that code before landing this and removing the bots completely. Maybe check
> w/ ojan@ or
> tansell@?

+ojan for removing XP bot from webkit

[ojan, 2016-01-20 18:33:57]

On 2016/01/20 at 01:07:00, jam wrote:
> On 2016/01/20 01:01:09, Dirk Pranke (slow) wrote:
> > The blink team's rebaseline-o-matic downloads files from the XP bot; we
should
> > turn off XP support
> > in that code before landing this and removing the bots completely. Maybe
check
> > w/ ojan@ or
> > tansell@?
> 
> +ojan for removing XP bot from webkit

Sorry for the delayed response. This is great. You just need to remove the
Webkit XP line from builders.py to keep the blink tooling happy.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Thanks for doing this!

[jam, 2016-01-20 20:30:30]

On 2016/01/20 18:33:57, ojan wrote:
> On 2016/01/20 at 01:07:00, jam wrote:
> > On 2016/01/20 01:01:09, Dirk Pranke (slow) wrote:
> > > The blink team's rebaseline-o-matic downloads files from the XP bot; we
> should
> > > turn off XP support
> > > in that code before landing this and removing the bots completely. Maybe
> check
> > > w/ ojan@ or
> > > tansell@?
> > 
> > +ojan for removing XP bot from webkit
> 
> Sorry for the delayed response. This is great. You just need to remove the
> Webkit XP line from builders.py to keep the blink tooling happy.
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Thanks for doing this!

Will do before the masters are restarted, thanks for the pointer.

[jam, 2016-01-20 20:30:42]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-01-20 20:30:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608713004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608713004/20001

[jam, 2016-01-20 20:39:10]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 20:39:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608713004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608713004/40001

[jam, 2016-01-20 20:41:01]

Patchset #3 (id:40001) has been deleted

[jam, 2016-01-20 20:41:08]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 20:41:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608713004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608713004/60001

[commit-bot: I haz the power, 2016-01-20 20:44:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 20:44:18]

Dry run: This issue passed the CQ dry run.

[jam, 2016-01-20 22:06:57]

I'll hold off on landing this till we can figure out how to test the NaCl
sandbox on 32 bit windows.

[jam, 2016-01-23 22:29:25]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-23 22:29:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608713004/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608713004/70001

[jam, 2016-01-23 22:30:08]

The CQ bit was unchecked by jam@chromium.org

[jam, 2016-01-25 15:28:54]

The CQ bit was checked by jam@chromium.org

[jam, 2016-01-25 15:28:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
sheyang@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1608713004/#ps70001
(title: "merge")

[commit-bot: I haz the power, 2016-01-25 15:28:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608713004/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608713004/70001

[commit-bot: I haz the power, 2016-01-25 15:40:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 15:40:46]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[Paweł Hajdan Jr., 2016-01-25 15:44:24]

phajdan.jr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-01-25 15:44:25]

LGTM w/comment

https://codereview.chromium.org/1608713004/diff/70001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/trybots.py (left):

https://codereview.chromium.org/1608713004/diff/70001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/trybots.py:447:
'win_chromium_xp_rel_ng': simple_bot({
Could you remove these from the tryserver master as well?

[jam, 2016-01-25 15:52:29]

https://codereview.chromium.org/1608713004/diff/70001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/trybots.py (left):

https://codereview.chromium.org/1608713004/diff/70001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/trybots.py:447:
'win_chromium_xp_rel_ng': simple_bot({
On 2016/01/25 15:44:25, Paweł Hajdan Jr. wrote:
> Could you remove these from the tryserver master as well?

Done.

[jam, 2016-01-25 15:52:37]

The CQ bit was checked by jam@chromium.org

[jam, 2016-01-25 15:52:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org, scottmg@chromium.org, sheyang@chromium.org
Link to the patchset: https://codereview.chromium.org/1608713004/#ps90001
(title: "update tryserver master

")

[commit-bot: I haz the power, 2016-01-25 15:52:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608713004/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608713004/90001

[commit-bot: I haz the power, 2016-01-25 15:56:06]

Description was changed from

==========
Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

BUG=579196
==========

to

==========
Remove XP and Vista bots from chromium.win and chromium.webkit waterfalls.

BUG=579196

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298385
==========

[commit-bot: I haz the power, 2016-01-25 15:56:07]

Committed patchset #5 (id:90001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298385