Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608693004: [interpreter] Simplify ConstantArrayBuilder interface a bit. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_int-2
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Simplify ConstantArrayBuilder interface a bit. R=oth@chromium.org Committed: https://crrev.com/1f506030cbce2c3709ea1c71b9e6024586febfd0 Cr-Commit-Position: refs/heads/master@{#33401}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 1 chunk +4 lines, -6 lines 1 comment Download
M src/interpreter/constant-array-builder.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/interpreter/constant-array-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/interpreter/constant-array-builder-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1607433005 Patch 120001

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Just a random cleanup, nothing fancy. https://codereview.chromium.org/1608693004/diff/1/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1608693004/diff/1/src/interpreter/bytecode-array-builder.cc#newcode158 src/interpreter/bytecode-array-builder.cc:158: output->set_handler_table(*handler_table); I could ...
4 years, 11 months ago (2016-01-19 16:38:55 UTC) #1
oth
lgtm
4 years, 11 months ago (2016-01-20 07:25:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608693004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608693004/1
4 years, 11 months ago (2016-01-20 11:08:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 11:31:26 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 11:32:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1f506030cbce2c3709ea1c71b9e6024586febfd0
Cr-Commit-Position: refs/heads/master@{#33401}

Powered by Google App Engine
This is Rietveld 408576698