[interpreter] Implement exception handler table building.

[interpreter] Implement exception handler table building.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n

Committed: https://crrev.com/82716f1ceafda78af661427ae38384d1c64e7902
Cr-Commit-Position: refs/heads/master@{#33400}

[Michael Starzinger, 2016-01-18 20:07:45]

Description was changed from

==========
[interpreter] Implement exception handler table buiding.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Implement exception handler table building.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

[Michael Starzinger, 2016-01-18 20:11:35]

Note that tests are still missing, but I wanted to get a first comment on this
to check whether the implementation is going into the right direction. Thanks!

[oth, 2016-01-19 09:20:08]

Looks great modulo tests.

[Michael Starzinger, 2016-01-19 09:39:15]

On 2016/01/19 09:20:08, oth wrote:
> Looks great modulo tests.

Thanks! As discussed offline, I will now start with the stack unwinding to
tackle the stuff with the most open questions while I am here. I will later one
come back to this CL and add tests before landing it.

[Michael Starzinger, 2016-01-19 16:29:30]

PTAL. Ready for final review.

[oth, 2016-01-20 08:01:33]

Looks great. LGTM. Perhaps a couple more tests for the paranoid.

https://codereview.chromium.org/1607433005/diff/120001/test/cctest/interprete...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1607433005/diff/120001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:4236: B(LdaSmi8), U8(1),     
                                       //
Tests are a bit brief. Could we add a couple of more, perhaps:

1) two try...catch...blocks not nested.
2) nested try...catch...finally.

[Michael Starzinger, 2016-01-20 10:19:54]

Thanks. Comments addressed. Landing.

https://codereview.chromium.org/1607433005/diff/120001/test/cctest/interprete...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1607433005/diff/120001/test/cctest/interprete...
test/cctest/interpreter/test-bytecode-generator.cc:4236: B(LdaSmi8), U8(1),     
                                       //
On 2016/01/20 08:01:33, oth wrote:
> Tests are a bit brief. Could we add a couple of more, perhaps:
> 
> 1) two try...catch...blocks not nested.
> 2) nested try...catch...finally.
> 

Done, (1) in the test above and (2) here.

[Michael Starzinger, 2016-01-20 10:26:31]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-01-20 10:26:32]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1607433005/#ps140001
(title: "Added moar tests.")

[commit-bot: I haz the power, 2016-01-20 10:26:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1607433005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1607433005/140001

[commit-bot: I haz the power, 2016-01-20 10:46:23]

Description was changed from

==========
[interpreter] Implement exception handler table building.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Implement exception handler table building.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

[commit-bot: I haz the power, 2016-01-20 10:46:24]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-01-20 10:47:24]

Description was changed from

==========
[interpreter] Implement exception handler table building.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n
==========

to

==========
[interpreter] Implement exception handler table building.

This implements a first version of exception handler table construction
within the interpreter. Note that the local control flow for try-catch
and try-finally statements is still off, and also stack unwinding does
not yet respect interpreter frames. But generated handler tables should
be populated correctly already.

R=oth@chromium.org
BUG=v8:4674
LOG=n

Committed: https://crrev.com/82716f1ceafda78af661427ae38384d1c64e7902
Cr-Commit-Position: refs/heads/master@{#33400}
==========

[commit-bot: I haz the power, 2016-01-20 10:47:25]

Patchset 8 (id:??) landed as
https://crrev.com/82716f1ceafda78af661427ae38384d1c64e7902
Cr-Commit-Position: refs/heads/master@{#33400}