src/x64/code-stubs-x64.cc - Issue 1608583002: New page local store buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 1608583002: New page local store buffer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Revert dynamic buckets Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index fff0c69fa98746e3b9809deda6164896c27878cb..a9b059e2ec5af81e6c99a204f6b3f47aa6cc451b 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -3957,11 +3957,8 @@ void RecordWriteStub::GenerateIncremental(MacroAssembler* masm, Mode mode) {

regs_.scratch0(),

&dont_need_remembered_set);

- __ CheckPageFlag(regs_.object(),

- regs_.scratch0(),

- 1 << MemoryChunk::SCAN_ON_SCAVENGE,

- not_zero,

- &dont_need_remembered_set);

+ __ JumpIfInNewSpace(regs_.object(), regs_.scratch0(),

+ &dont_need_remembered_set);

// First notify the incremental marker if necessary, then update the

// remembered set.