Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1608113002: Revert of media/vpx: Add support for VP9 alpha channel (Closed)

Created:
4 years, 11 months ago by benwells
Modified:
4 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media/vpx: Add support for VP9 alpha channel (patchset #6 id:100001 of https://codereview.chromium.org/1561703002/ ) Reason for revert: The new test is timing out on the ChromeOS valgrind bot. It isn't clear if this is because the test is too slow for that bot (tests on valgrind bots typically take longer to run) or if there is a real problem. See log here: https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%281%29/builds/40697/steps/memory%20test%3A%20media/logs/stdio Original issue's description: > media/vpx: Add support for VP9 alpha channel > > Not supporting VP9 alpha channel in WebM is an artificial > restriction. This patch removes that restriction and adds a test. > > TEST=<media pipeline integration test should pass> > > Committed: https://crrev.com/4863f9bda1800e1da901588ffd995364aaa70d8e > Cr-Commit-Position: refs/heads/master@{#370147} TBR=tomfinegan@chromium.org,dalecurtis@chromium.org,vigneshv@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/7eccd9783e1941bed15eef28365f0bed431728a1 Cr-Commit-Position: refs/heads/master@{#370282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -196 lines) Patch
M media/base/video_frame.h View 1 chunk +0 lines, -17 lines 0 comments Download
M media/base/video_frame.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 2 chunks +0 lines, -14 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 7 chunks +63 lines, -96 lines 0 comments Download
D media/test/data/bear-vp9a.webm View Binary file 0 comments Download
D media/test/data/bear-vp9a-odd-dimensions.webm View Binary file 0 comments Download
M media/test/pipeline_integration_test.cc View 7 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
benwells
Created Revert of media/vpx: Add support for VP9 alpha channel
4 years, 11 months ago (2016-01-20 02:17:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608113002/1
4 years, 11 months ago (2016-01-20 02:20:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 02:23:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7eccd9783e1941bed15eef28365f0bed431728a1 Cr-Commit-Position: refs/heads/master@{#370282}
4 years, 11 months ago (2016-01-20 02:24:52 UTC) #6
vignesh
4 years, 11 months ago (2016-01-21 02:56:26 UTC) #7
Message was sent while issue was closed.
Dale,

I tried running the tests on valgrind locally and they are passing. Any idea
what could be going on here?

Powered by Google App Engine
This is Rietveld 408576698