Fix errors when building android with coverage=1

Fix errors when building android with coverage=1

Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc

BUG=245467
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204556

[rwalker, 2013-06-04 21:22:40]

thanks for looking

[Isaac (away), 2013-06-04 21:29:18]

Thanks for sending a review!  The best way to find a reviewer for your code is
to look at recent editors the the files in question, or look for an OWNERS file.

-> to willchan@ for review.

[willchan no longer on Chromium, 2013-06-04 21:33:46]

First, thank you for your code contribution. There's some amount of bureaucracy
we have to require you take care of first before I can approve this. See
http://www.chromium.org/developers/contributing-code for details. I have to
follow
http://www.chromium.org/developers/contributing-code/external-contributor-che...
when reviewing your CL.

In particular, you need to add yourself to the AUTHORS file in this changelist
and also fill out the CLA. I will then verify that you've signed that document
and then I can approve this change.

[willchan no longer on Chromium, 2013-06-04 21:34:36]

Google C++ style guide discourages use of C-style casts.

https://codereview.chromium.org/16077010/diff/1/base/linux_util.cc
File base/linux_util.cc (right):

https://codereview.chromium.org/16077010/diff/1/base/linux_util.cc#newcode234
base/linux_util.cc:234: ino_t fd_inode = (ino_t)-1;
Please use a static_cast<> here instead.

[willchan no longer on Chromium, 2013-06-04 23:28:17]

Thanks for the patchset update. The only thing I'm not seeing yet is the CLA
form getting filled out. Let me know when you've done that and I'll check again.

[rwalker, 2013-06-04 23:59:42]

On 2013/06/04 23:28:17, willchan wrote:
> Thanks for the patchset update. The only thing I'm not seeing yet is the CLA
> form getting filled out. Let me know when you've done that and I'll check
again.

I looked at the CLA requirements.  I can't review the CLA list Googlers have,
but I have this hint:

'If there's a corporate CLA for the author's company (should be one for either
Code Aurora Foundation, or Qualcomm, or Qualcomm Innovation Center), it must
list the person explicitly (or the list of authorized contributors must say
something like "All employees"). If the author is not on their company's roster,
do not accept the change.'

From my side, I understand we have "All Employees" in our agreement.  I wish I
could supply a better pointer into your CLA list...

Thanks,
Rob

[willchan no longer on Chromium, 2013-06-05 00:16:22]

I'm consulting mal@ on this. I'll report back when I hear from him about the
status of those organizations. I fear neither you nor I are knowledgable about
this bureaucratic stuff.

[willchan no longer on Chromium, 2013-06-05 03:43:09]

OK, mal@ pointed out I'm a n00b and missed the corporate signers tab, which
listed Code Aurora. You're good to go. LGTM.

[Isaac (away), 2013-06-05 03:51:17]

Since all members have signed, could you change the authors line to:

Code Aurora Forum <*@codeaurora.com>

?  Thanks.

[Isaac (away), 2013-06-05 21:20:12]

lgtm

[Isaac (away), 2013-06-05 21:21:26]

how did you upload this code?  There's no baseurl?

[rwalker, 2013-06-05 22:11:49]

On 2013/06/05 21:21:26, Isaac wrote:
> how did you upload this code?  There's no baseurl?

I have a NewGit chromium tree.  I used:

upload.py -s codereview.chromium.org --rev 2df373b14 -i 16077010

[rwalker, 2013-06-05 22:27:49]

set baseurl

[rwalker, 2013-06-05 22:33:43]

another attempt at setting baseurl

[rwalker, 2013-06-05 22:33:50]

I've set baseurl for git-cl, now, but that doesn't seem to be propogated during
upload.  Maybe I'm using the wrong form?

[rwalker@ruffian src]$ git cl baseurl
Current base-url:
http://chromium.googlesource.com/chromium/src.git
[rwalker@ruffian src]$ git cl upload --rev 2df373b14 -m "set baseurl"
...

[rwalker, 2013-06-05 22:38:18]

2nd attempt to set baseurl:

[rwalker@ruffian src]$ git cl issue
Issue number: 16077010 (https://codereview.chromium.org/16077010)
[rwalker@ruffian src]$ git cl baseurl $(git remote -v | awk '/fetch/ {print
$2}')@2df373b148417a38438e3f1492c274076e70d943
[rwalker@ruffian src]$ git cl baseurl
Current base-url:
http://chromium.googlesource.com/chromium/src.git@2df373b148417a38438e3f1492c...
[rwalker@ruffian src]$ git cl upload -m "another attempt at setting baseurl"
...

[Isaac (away), 2013-06-05 22:59:54]

You can't set baseurl on an existing issue.  I'll see if I can set one for you. 
Please use git cl upload in the future -- it will work better :-)

[Isaac (away), 2013-06-06 19:48:04]

Closing issue and relanding here:
https://chromiumcodereview.appspot.com/16589002/

[commit-bot: I haz the power, 2013-06-06 19:49:18]

Change committed as 204556