Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/activity_log/activity_log.cc

Issue 160753002: Enables Activity Log to extract URLs from URL assignment API calls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_log_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_log.cc
diff --git a/chrome/browser/extensions/activity_log/activity_log.cc b/chrome/browser/extensions/activity_log/activity_log.cc
index 6fc02361fc4cfd51f973abcdfe3c7c2deb4046d4..64edc9646e5d78a082f75afdc6469867e12cae93 100644
--- a/chrome/browser/extensions/activity_log/activity_log.cc
+++ b/chrome/browser/extensions/activity_log/activity_log.cc
@@ -92,46 +92,64 @@ struct ApiInfo {
};
static const ApiInfo kApiInfoTable[] = {
- // Tabs APIs that require tab ID translation
- {Action::ACTION_API_CALL, "tabs.connect", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.detectLanguage", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.duplicate", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.executeScript", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.get", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.insertCSS", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.move", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.reload", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.remove", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.sendMessage", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_CALL, "tabs.update", 0, LOOKUP_TAB_ID, NULL},
-
- {Action::ACTION_API_EVENT, "tabs.onUpdated", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_EVENT, "tabs.onMoved", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_EVENT, "tabs.onDetached", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_EVENT, "tabs.onAttached", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_EVENT, "tabs.onRemoved", 0, LOOKUP_TAB_ID, NULL},
- {Action::ACTION_API_EVENT, "tabs.onReplaced", 0, LOOKUP_TAB_ID, NULL},
-
- // Other APIs that accept URLs as strings
- {Action::ACTION_API_CALL, "bookmarks.create", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "bookmarks.update", 1, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "cookies.get", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "cookies.getAll", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "cookies.remove", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "cookies.set", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "downloads.download", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "history.addUrl", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "history.deleteUrl", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "history.getVisits", 0, DICT_LOOKUP, "url"},
- {Action::ACTION_API_CALL, "webstore.install", 0, NONE, NULL},
- {Action::ACTION_API_CALL, "windows.create", 0, DICT_LOOKUP, "url"},
-
- {Action::ACTION_DOM_ACCESS, "Document.location", 0, NONE, NULL},
- {Action::ACTION_DOM_ACCESS, "Location.assign", 0, NONE, NULL},
- {Action::ACTION_DOM_ACCESS, "Location.replace", 0, NONE, NULL},
- {Action::ACTION_DOM_ACCESS, "Window.location", 0, NONE, NULL},
- {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open", 1, NONE, NULL},
-};
+ // Tabs APIs that require tab ID translation
+ {Action::ACTION_API_CALL, "tabs.connect", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.detectLanguage", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.duplicate", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.executeScript", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.get", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.insertCSS", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.move", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.reload", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.remove", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.sendMessage", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_CALL, "tabs.update", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_EVENT, "tabs.onUpdated", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_EVENT, "tabs.onMoved", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_EVENT, "tabs.onDetached", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_EVENT, "tabs.onAttached", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_EVENT, "tabs.onRemoved", 0, LOOKUP_TAB_ID, NULL},
+ {Action::ACTION_API_EVENT, "tabs.onReplaced", 0, LOOKUP_TAB_ID, NULL},
+
+ // Other APIs that accept URLs as strings
+ {Action::ACTION_API_CALL, "bookmarks.create", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "bookmarks.update", 1, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "cookies.get", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "cookies.getAll", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "cookies.remove", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "cookies.set", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "downloads.download", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "history.addUrl", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "history.deleteUrl", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "history.getVisits", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_API_CALL, "webstore.install", 0, NONE, NULL},
+ {Action::ACTION_API_CALL, "windows.create", 0, DICT_LOOKUP, "url"},
+ {Action::ACTION_DOM_ACCESS, "Document.location", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "Location.assign", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "Location.replace", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "Window.location", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open", 1, NONE, NULL},
mvrable 2014/02/12 19:50:08 Could you keep the list sorted instead of adding y
pmarch 2014/02/12 20:29:53 Done.
+ {Action::ACTION_DOM_ACCESS, "HTMLButtonElement.formAction", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLEmbedElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLFormElement.action", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLFrameElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLHtmlElement.manifest", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLIFrameElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLImageElement.longDesc", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLImageElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLImageElement.lowsrc", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLInputElement.formAction", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLInputElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLLinkElement.href", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLMediaElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLMediaElement.currentSrc", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLModElement.cite", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLObjectElement.data", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLQuoteElement.cite", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLScriptElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLSourceElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLTrackElement.src", 0, NONE, NULL},
+ {Action::ACTION_DOM_ACCESS, "HTMLVideoElement.poster", 0, NONE, NULL}};
// A singleton class which provides lookups into the kApiInfoTable data
// structure. It inserts all data into a map on first lookup.
« no previous file with comments | « no previous file | chrome/browser/extensions/activity_log/activity_log_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698