Enables Activity Log to extract URLs from URL assignment API calls

chrome/browser/extensions/activity_log/activity_log.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/activity_log/activity_log.h"
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 74 matching lines @@
   // IDs which are translated.
   //
   // If DICT_LOOKUP, the data is expected to be a dictionary, and
   // arg_url_dict_path is a path (list of keys delimited by ".") where a URL
   // string is to be found.
   Transformation arg_url_transform;
   const char* arg_url_dict_path;
 };
 
 static const ApiInfo kApiInfoTable[] = {
-  // Tabs APIs that require tab ID translation
-  {Action::ACTION_API_CALL, "tabs.connect", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.detectLanguage", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.duplicate", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.executeScript", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.get", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.insertCSS", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.move", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.reload", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.remove", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.sendMessage", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_CALL, "tabs.update", 0, LOOKUP_TAB_ID, NULL},
+    // Tabs APIs that require tab ID translation
+    {Action::ACTION_API_CALL, "tabs.connect", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.detectLanguage", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.duplicate", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.executeScript", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.get", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.insertCSS", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.move", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.reload", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.remove", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.sendMessage", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_CALL, "tabs.update", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_EVENT, "tabs.onUpdated", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_EVENT, "tabs.onMoved", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_EVENT, "tabs.onDetached", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_EVENT, "tabs.onAttached", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_EVENT, "tabs.onRemoved", 0, LOOKUP_TAB_ID, NULL},
+    {Action::ACTION_API_EVENT, "tabs.onReplaced", 0, LOOKUP_TAB_ID, NULL},
 
-  {Action::ACTION_API_EVENT, "tabs.onUpdated", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_EVENT, "tabs.onMoved", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_EVENT, "tabs.onDetached", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_EVENT, "tabs.onAttached", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_EVENT, "tabs.onRemoved", 0, LOOKUP_TAB_ID, NULL},
-  {Action::ACTION_API_EVENT, "tabs.onReplaced", 0, LOOKUP_TAB_ID, NULL},
-
-  // Other APIs that accept URLs as strings
-  {Action::ACTION_API_CALL, "bookmarks.create", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "bookmarks.update", 1, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "cookies.get", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "cookies.getAll", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "cookies.remove", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "cookies.set", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "downloads.download", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "history.addUrl", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "history.deleteUrl", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "history.getVisits", 0, DICT_LOOKUP, "url"},
-  {Action::ACTION_API_CALL, "webstore.install", 0, NONE, NULL},
-  {Action::ACTION_API_CALL, "windows.create", 0, DICT_LOOKUP, "url"},
-
-  {Action::ACTION_DOM_ACCESS, "Document.location", 0, NONE, NULL},
-  {Action::ACTION_DOM_ACCESS, "Location.assign", 0, NONE, NULL},
-  {Action::ACTION_DOM_ACCESS, "Location.replace", 0, NONE, NULL},
-  {Action::ACTION_DOM_ACCESS, "Window.location", 0, NONE, NULL},
-  {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open", 1, NONE, NULL},
-};
+    // Other APIs that accept URLs as strings
+    {Action::ACTION_API_CALL, "bookmarks.create", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "bookmarks.update", 1, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "cookies.get", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "cookies.getAll", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "cookies.remove", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "cookies.set", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "downloads.download", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "history.addUrl", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "history.deleteUrl", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "history.getVisits", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_API_CALL, "webstore.install", 0, NONE, NULL},
+    {Action::ACTION_API_CALL, "windows.create", 0, DICT_LOOKUP, "url"},
+    {Action::ACTION_DOM_ACCESS, "Document.location", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "Location.assign", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "Location.replace", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "Window.location", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open", 1, NONE, NULL},

[mvrable, 2014/02/12 19:50:08]

Could you keep the list sorted instead of adding your entries at the end?

[pmarch, 2014/02/12 20:29:53]

Done.

+    {Action::ACTION_DOM_ACCESS, "HTMLButtonElement.formAction", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLEmbedElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLFormElement.action", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLFrameElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLHtmlElement.manifest", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLIFrameElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLImageElement.longDesc", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLImageElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLImageElement.lowsrc", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLInputElement.formAction", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLInputElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLLinkElement.href", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLMediaElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLMediaElement.currentSrc", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLModElement.cite", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLObjectElement.data", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLQuoteElement.cite", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLScriptElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLSourceElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLTrackElement.src", 0, NONE, NULL},
+    {Action::ACTION_DOM_ACCESS, "HTMLVideoElement.poster", 0, NONE, NULL}};
 
 // A singleton class which provides lookups into the kApiInfoTable data
 // structure.  It inserts all data into a map on first lookup.
 class ApiInfoDatabase {
  public:
   static ApiInfoDatabase* GetInstance() {
     return Singleton<ApiInfoDatabase>::get();
   }
 
   // Retrieves an ApiInfo record for the given Action type.  Returns either a
@@ skipping 541 matching lines @@
   RemoveURLs(urls);
 }
 
 void ActivityLog::DeleteDatabase() {
   if (!database_policy_)
     return;
   database_policy_->DeleteDatabase();
 }
 
 }  // namespace extensions