Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 160753002: Enables Activity Log to extract URLs from URL assignment API calls (Closed)

Created:
6 years, 10 months ago by pmarch
Modified:
6 years, 10 months ago
Reviewers:
felt, mvrable
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enables Activity Log to extract URLs from URL assignment DOM API calls and place them into argUrl field of an Activity Log entry. BUG=339882 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251348

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -40 lines) Patch
M chrome/browser/extensions/activity_log/activity_log.cc View 1 2 1 chunk +58 lines, -40 lines 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 3 chunks +65 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
pmarch
Could you please review this CL before the branch point which is this Friday. Thank ...
6 years, 10 months ago (2014-02-12 19:10:03 UTC) #1
mvrable
lgtm https://codereview.chromium.org/160753002/diff/30001/chrome/browser/extensions/activity_log/activity_log.cc File chrome/browser/extensions/activity_log/activity_log.cc (right): https://codereview.chromium.org/160753002/diff/30001/chrome/browser/extensions/activity_log/activity_log.cc#newcode131 chrome/browser/extensions/activity_log/activity_log.cc:131: {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open", 1, NONE, NULL}, Could you keep ...
6 years, 10 months ago (2014-02-12 19:50:07 UTC) #2
pmarch
https://codereview.chromium.org/160753002/diff/30001/chrome/browser/extensions/activity_log/activity_log.cc File chrome/browser/extensions/activity_log/activity_log.cc (right): https://codereview.chromium.org/160753002/diff/30001/chrome/browser/extensions/activity_log/activity_log.cc#newcode131 chrome/browser/extensions/activity_log/activity_log.cc:131: {Action::ACTION_DOM_ACCESS, "XMLHttpRequest.open", 1, NONE, NULL}, On 2014/02/12 19:50:08, mvrable ...
6 years, 10 months ago (2014-02-12 20:29:52 UTC) #3
felt
lgtm
6 years, 10 months ago (2014-02-13 01:02:46 UTC) #4
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 10 months ago (2014-02-13 18:34:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/160753002/90001
6 years, 10 months ago (2014-02-13 18:36:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/160753002/90001
6 years, 10 months ago (2014-02-13 19:58:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 00:19:50 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=201771
6 years, 10 months ago (2014-02-14 00:19:50 UTC) #9
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 10 months ago (2014-02-14 02:34:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/160753002/90001
6 years, 10 months ago (2014-02-14 02:41:32 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 05:49:20 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202021
6 years, 10 months ago (2014-02-14 05:49:20 UTC) #13
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 10 months ago (2014-02-14 12:49:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/160753002/90001
6 years, 10 months ago (2014-02-14 12:51:30 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 15:36:22 UTC) #16
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=202261
6 years, 10 months ago (2014-02-14 15:36:22 UTC) #17
pmarch
The CQ bit was checked by pmarch@chromium.org
6 years, 10 months ago (2014-02-14 15:36:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pmarch@chromium.org/160753002/90001
6 years, 10 months ago (2014-02-14 15:37:26 UTC) #19
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 16:35:01 UTC) #20
Message was sent while issue was closed. 
Change committed as 251348

Powered by Google App Engine
This is Rietveld 408576698