MD History: Display synced tabs history

MD History: Display synced tabs history 

Synced tabs cards are collapsible. Added a sidebar to navigate between history 
and synced tabs view.

BUG=425625

[yingran, 2016-01-21 00:55:25]

yingran@google.com changed reviewers:
+ calamity@chromium.org, tsergeant@chromium.org

[yingran, 2016-01-21 03:32:19]

Description was changed from

==========
Display synced history. Added a sidebar to navigate between history and synced
tabs view.

BUG=425625
==========

to

==========
MD History: Display synced tabs history. Synced tabs cards are collapsible.
Added a sidebar to navigate between history and synced tabs view.

BUG=425625
==========

[yingran, 2016-01-21 03:33:40]

Description was changed from

==========
MD History: Display synced tabs history. Synced tabs cards are collapsible.
Added a sidebar to navigate between history and synced tabs view.

BUG=425625
==========

to

==========
MD History: Display synced tabs history 

Synced tabs cards are collapsible. Added a sidebar to navigate between history 
and synced tabs view.

BUG=425625
==========

[yingran, 2016-01-22 05:41:49]

Patchset #8 (id:140001) has been deleted

[yingran, 2016-01-22 05:41:55]

Patchset #7 (id:120001) has been deleted

[yingran, 2016-01-22 05:41:59]

Patchset #6 (id:100001) has been deleted

[yingran, 2016-02-02 03:00:56]

Patchset #7 (id:180001) has been deleted

[calamity, 2016-02-02 04:09:48]

First pass.

I foresee epic merge fun when hannah tries to land some of her stuff.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/history.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/history.js:81:
$('synced-device-manager').hidden = true;
Use $().hidden = e.detail.display == 'history' or 'synced-tabs'.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.html:34: <div
on-tap="showSyncedTabs" id="tab-button" class="nav-button">
synced-tabs-button?

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.html:35: <p id="synced-tabs">Open
Tabs</p>
These text elements shouldn't need ids.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.js:39: showHistory: function() {
Needing both of these is kinda lame. You should be able to make a generic
'showTab' method instead which sends the id of the button being clicked.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.js:48:
this.$['synced-tabs'].style.color = '#333';
Use a CSS style that changes between these when an attribute is set. Setting
styles in JS is messy.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:83:
-webkit-padding-start: 0.3em;
Hmm. Maybe nbsp is the right thing to use here? (Tim, halp)

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:94: }
Too much shared style!

Consider:
https://www.polymer-project.org/1.0/docs/devguide/styling.html#style-modules

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:98: <div id="title"
aria-expanded$="[[isExpanded(cardOpen)]]"
Let's get rid of this isExpanded stuff.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:116: <p
on-tap="openAllTabs_" id="open-tabs">Open all in new tab(s)</p>
This gon need some i18n.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:9: // The name of the
synced tab device.
nit: synced device.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:14: // The approximate
time of when the tabs on the device was last updated.
// When the device information was last updated.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:19: // The list of
tabs open for each synced device.
for this device.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:22: value: [],
Does this do that wacky static thing? Should this be function() { return []; } ?

Tim?

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:25: // Whether the
synced tab display for the device is open.
// Whether this card is open.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:40: }
Why not use normal history's implementation?

See other_devices.js:123

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:49:
((this.$$('#dropdown-indicator').icon == 'expand-less') ?
Use this.$.collapse.opened.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:54: * Converst a
boolean to a string.
Letters reverst.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_manager.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.html:17: }
Pretty sure this does nothing. I think you can also get rid of the container div
completely.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.js:10: syncedTabs: {
syncedDevices?

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.js:31: tabs:
sessionList[i].windows[0].tabs,
Only 1 window? We should also have a horizontal line or something to separate
windows.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/md_history_ui.cc:43: 
nit: stray newline.

[yingran, 2016-02-03 00:50:05]

Patchset #7 (id:200001) has been deleted

[tsergeant, 2016-02-03 03:00:00]

Review review:

Solid code review, 9/10

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:83:
-webkit-padding-start: 0.3em;
On 2016/02/02 04:09:47, calamity wrote:
> Hmm. Maybe nbsp is the right thing to use here? (Tim, halp)

uuuuuhhhh, I'm mostly impartial. If nbsp looks the same, go for it, it's
probably marginally nicer.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:22: value: [],
On 2016/02/02 04:09:47, calamity wrote:
> Does this do that wacky static thing? Should this be function() { return []; }
?
> 
> Tim?

Apparently, yes.

[yingran, 2016-02-09 04:21:35]

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/history.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/history.js:81:
$('synced-device-manager').hidden = true;
On 2016/02/02 04:09:47, calamity wrote:
> Use $().hidden = e.detail.display == 'history' or 'synced-tabs'.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.html:34: <div
on-tap="showSyncedTabs" id="tab-button" class="nav-button">
On 2016/02/02 04:09:47, calamity wrote:
> synced-tabs-button?

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.html:35: <p id="synced-tabs">Open
Tabs</p>
On 2016/02/02 04:09:47, calamity wrote:
> These text elements shouldn't need ids.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.js:39: showHistory: function() {
On 2016/02/02 04:09:47, calamity wrote:
> Needing both of these is kinda lame. You should be able to make a generic
> 'showTab' method instead which sends the id of the button being clicked.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.js:48:
this.$['synced-tabs'].style.color = '#333';
On 2016/02/02 04:09:47, calamity wrote:
> Use a CSS style that changes between these when an attribute is set. Setting
> styles in JS is messy.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:83:
-webkit-padding-start: 0.3em;
On 2016/02/03 03:00:00, tsergeant wrote:
> On 2016/02/02 04:09:47, calamity wrote:
> > Hmm. Maybe nbsp is the right thing to use here? (Tim, halp)
> 
> uuuuuhhhh, I'm mostly impartial. If nbsp looks the same, go for it, it's
> probably marginally nicer.

It adds a slightly fatter space so I'm gunna leave it as is for now...

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:94: }
On 2016/02/02 04:09:47, calamity wrote:
> Too much shared style!
> 
> Consider:
> https://www.polymer-project.org/1.0/docs/devguide/styling.html#style-modules

Done.

still a lot of shared styles with history item as well- but this will be added
in my refactor

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:98: <div id="title"
aria-expanded$="[[isExpanded(cardOpen)]]"
On 2016/02/02 04:09:47, calamity wrote:
> Let's get rid of this isExpanded stuff.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:116: <p
on-tap="openAllTabs_" id="open-tabs">Open all in new tab(s)</p>
On 2016/02/02 04:09:47, calamity wrote:
> This gon need some i18n.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:9: // The name of the
synced tab device.
On 2016/02/02 04:09:48, calamity wrote:
> nit: synced device.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:14: // The approximate
time of when the tabs on the device was last updated.
On 2016/02/02 04:09:48, calamity wrote:
> // When the device information was last updated.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:19: // The list of
tabs open for each synced device.
On 2016/02/02 04:09:48, calamity wrote:
> for this device.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:22: value: [],
On 2016/02/03 03:00:00, tsergeant wrote:
> On 2016/02/02 04:09:47, calamity wrote:
> > Does this do that wacky static thing? Should this be function() { return [];
}
> ?
> > 
> > Tim?
> 
> Apparently, yes.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:25: // Whether the
synced tab display for the device is open.
On 2016/02/02 04:09:48, calamity wrote:
> // Whether this card is open.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:40: }
On 2016/02/02 04:09:47, calamity wrote:
> Why not use normal history's implementation?
> 
> See other_devices.js:123

Is there a place where I can see what I have to input for chrome.send functions?
Currently I don't know how to do this because it's not very well documented in
other_devices.js

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:49:
((this.$$('#dropdown-indicator').icon == 'expand-less') ?
On 2016/02/02 04:09:48, calamity wrote:
> Use this.$.collapse.opened.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:54: * Converst a
boolean to a string.
On 2016/02/02 04:09:47, calamity wrote:
> Letters reverst.

=___=

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_manager.html (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.html:17: }
On 2016/02/02 04:09:48, calamity wrote:
> Pretty sure this does nothing. I think you can also get rid of the container
div
> completely.

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.js:10: syncedTabs: {
On 2016/02/02 04:09:48, calamity wrote:
> syncedDevices?

Done.

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.js:31: tabs:
sessionList[i].windows[0].tabs,
On 2016/02/02 04:09:48, calamity wrote:
> Only 1 window? We should also have a horizontal line or something to separate
> windows.

Coming soon, in another CL!

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/md_history_ui.cc (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/ui/webu...
chrome/browser/ui/webui/md_history_ui.cc:43: 
On 2016/02/02 04:09:48, calamity wrote:
> nit: stray newline.

Done.

[calamity, 2016-02-11 00:23:31]

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:54: * Converst a
boolean to a string.
On 2016/02/09 04:21:34, yingran wrote:
> On 2016/02/02 04:09:47, calamity wrote:
> > Letters reverst.
> 
> =___=

ಠ_ಠ

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.js:31: tabs:
sessionList[i].windows[0].tabs,
On 2016/02/09 04:21:34, yingran wrote:
> On 2016/02/02 04:09:48, calamity wrote:
> > Only 1 window? We should also have a horizontal line or something to
separate
> > windows.
> 
> Coming soon, in another CL!

Can we have tabs from all windows, unsplit? That would be a better intermediate
step.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/history.js (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/history.js:71:
$('history-card-manager').hidden = e.detail.display == 'synced-tabs-button';
Invert this.

$('synced..').hidden = ... != 'synced..'

Then the line is generalizable for other pages! So elegant. Much wow.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/history.js:105: }
This whole thing would be shorter if you extracted $().hidden =
!isTabSyncEnabled.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:8: }
Don't think it makes sense to have :host in here.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:10: #main-container {
This needs a better name now.

history-item-container perhaps?

Actually, this may not work with the refactor anymore..

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:19: #card-title {
These should all be classes.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.html:30: cursor: default;
I think it makes sense to have the same cursor for selected and unselected
items. I mean, it still ripples after you click it so it's weird to have a
different cursor.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.js:23:
Polymer.dom(this.root).querySelector('#' + e.currentTarget.id);
Can't you just use e.currentTarget?

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:25: }
These can be shared w/ history item.

.history-item-link perhaps.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:38: }
Can this be shared too?

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:9: // Synced device.
// Name of the synced device?

[yingran, 2016-02-11 02:06:36]

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/1607403004/diff/160001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_manager.js:31: tabs:
sessionList[i].windows[0].tabs,
On 2016/02/11 00:23:31, calamity wrote:
> On 2016/02/09 04:21:34, yingran wrote:
> > On 2016/02/02 04:09:48, calamity wrote:
> > > Only 1 window? We should also have a horizontal line or something to
> separate
> > > windows.
> > 
> > Coming soon, in another CL!
> 
> Can we have tabs from all windows, unsplit? That would be a better
intermediate
> step.

they already appear... as in all tabs from all windows appear...even though it's
just windows[0].tabs

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/history.js (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/history.js:71:
$('history-card-manager').hidden = e.detail.display == 'synced-tabs-button';
On 2016/02/11 00:23:31, calamity wrote:
> Invert this.
> 
> $('synced..').hidden = ... != 'synced..'
> 
> Then the line is generalizable for other pages! So elegant. Much wow.

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/history.js:105: }
On 2016/02/11 00:23:31, calamity wrote:
> This whole thing would be shorter if you extracted $().hidden =
> !isTabSyncEnabled.

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/shared_style.html (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:8: }
On 2016/02/11 00:23:31, calamity wrote:
> Don't think it makes sense to have :host in here.

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:10: #main-container {
On 2016/02/11 00:23:31, calamity wrote:
> This needs a better name now.
> 
> history-item-container perhaps?
> 
> Actually, this may not work with the refactor anymore..

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/shared_style.html:19: #card-title {
On 2016/02/11 00:23:31, calamity wrote:
> These should all be classes.

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.html (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.html:30: cursor: default;
On 2016/02/11 00:23:31, calamity wrote:
> I think it makes sense to have the same cursor for selected and unselected
> items. I mean, it still ripples after you click it so it's weird to have a
> different cursor.

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/side_bar.js (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/side_bar.js:23:
Polymer.dom(this.root).querySelector('#' + e.currentTarget.id);
On 2016/02/11 00:23:31, calamity wrote:
> Can't you just use e.currentTarget?

nup

polymer-mini-extracted.js:1233 Uncaught SyntaxError: Failed to execute
'querySelector' on 'DocumentFragment': '[object HTMLDivElement]' is not a valid
selector.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.html (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:25: }
On 2016/02/11 00:23:31, calamity wrote:
> These can be shared w/ history item.
> 
> .history-item-link perhaps.

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.html:38: }
On 2016/02/11 00:23:31, calamity wrote:
> Can this be shared too?

Done.

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
File chrome/browser/resources/md_history/synced_device_card.js (right):

https://codereview.chromium.org/1607403004/diff/220001/chrome/browser/resourc...
chrome/browser/resources/md_history/synced_device_card.js:9: // Synced device.
On 2016/02/11 00:23:31, calamity wrote:
> // Name of the synced device?

Done.