chrome/browser/resources/md_history/shared_style.html - Issue 1607403004: MD History: Display synced tabs history

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/shared_style.html

Issue 1607403004: MD History: Display synced tabs history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@second_patch

Patch Set: Changed switching between pages & addressed comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/md_history/history.js ('K') | « chrome/browser/resources/md_history/history_card.html ('k') | chrome/browser/resources/md_history/side_bar.html » ('j') | chrome/browser/resources/md_history/side_bar.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <dom-module id="shared-style">

	2 <template>

	3 <style>

	4 :host {

	5 @apply(--layout-center);

	6 @apply(--layout-vertical);

	7 padding: 0 24px 20px 24px;

	8 }
	calamity 2016/02/11 00:23:31 Don't think it makes sense to have :host in here. Don't think it makes sense to have :host in here. yingran 2016/02/11 02:06:36 Done. Show quoted text On 2016/02/11 00:23:31, calamity wrote: > Don't think it makes sense to have :host in here. Done.
	9

	10 #main-container {
	calamity 2016/02/11 00:23:31 This needs a better name now. history-item-contai This needs a better name now. history-item-container perhaps? Actually, this may not work with the refactor anymore.. yingran 2016/02/11 02:06:36 Done. Show quoted text On 2016/02/11 00:23:31, calamity wrote: > This needs a better name now. > > history-item-container perhaps? > > Actually, this may not work with the refactor anymore.. Done.
	11 @apply(--shadow-elevation-2dp);

	12 background: #fff;

	13 border-radius: 2px;

	14 max-width: 960px;

	15 min-width: 500px;

	16 width: 100%;

	17 }

	18

	19 #card-title {
	calamity 2016/02/11 00:23:31 These should all be classes. These should all be classes. yingran 2016/02/11 02:06:36 Done. Show quoted text On 2016/02/11 00:23:31, calamity wrote: > These should all be classes. Done.
	20 @apply(--layout-center);

	21 @apply(--layout-horizontal);

	22 -webkit-padding-start: 20px;

	23 background: #fafafa;

	24 border-bottom: 1px solid rgba(0, 0, 0, 0.14);

	25 border-radius: 2px 2px 0 0;

	26 color: #333;

	27 font-size: 14px;

	28 font-weight: 500;

	29 height: 48px;

	30 }

	31 </style>

	32 </template>

	33 </dom-module>

OLD	NEW