Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1607373002: dart2js: switching isolate is not 'PURE' (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
sra1
4 years, 11 months ago (2016-01-20 19:04:54 UTC) #2
asgerf
LGTM https://codereview.chromium.org/1607373002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1607373002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode2913 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2913: NativeBehavior.CHANGES_STATIC_PROPERTY); I would argue that this should use ...
4 years, 11 months ago (2016-01-20 19:09:55 UTC) #3
sra1
Committed patchset #2 (id:20001) manually as bbd105f10683fddf408b3560c20780fd95db684e (presubmit successful).
4 years, 11 months ago (2016-01-20 20:34:19 UTC) #5
sra1
4 years, 11 months ago (2016-01-20 20:59:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
d43365998d6b9bc5235ed492b1236c45a55e719b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698