dart2js: switching isolate is not 'PURE'

pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_builder_task;
 
 import '../closure.dart' as closure;
 import '../common.dart';
 import '../common/names.dart' show
     Names,
@@ skipping 2892 matching lines @@
             NativeBehavior.PURE);
 
       case 'JS_SET_STATIC_STATE':
         validateArgumentCount(exactly: 1);
 
         ir.Primitive value = visit(argumentNodes.single);
         String isolateName = backend.namer.staticStateHolder;
         return irBuilder.buildForeignCode(
             js.js.parseForeignJS("$isolateName = #"),
             <ir.Primitive>[value],
-            NativeBehavior.PURE);
+            NativeBehavior.CHANGES_STATIC_PROPERTY);

[asgerf, 2016/01/20 19:09:55]

I would argue that this should use the "other" flag once we get that. Maybe we
should create an issue to track that.

 
       case 'JS_CALL_IN_ISOLATE':
         validateArgumentCount(exactly: 2);
 
         if (!compiler.hasIsolateSupport) {
           ir.Primitive closure = visit(argumentNodes.tail.head);
           return irBuilder.buildCallInvocation(closure, CallStructure.NO_ARGS,
               const <ir.Primitive>[]);
         }
         return buildIsolateHelperInvocation(helpers.callInIsolate,
@@ skipping 629 matching lines @@
   }
 
   Element get closureConverter {
     return _backend.helpers.closureConverter;
   }
 
   void addNativeMethod(FunctionElement function) {
     _backend.emitter.nativeEmitter.nativeMethods.add(function);
   }
 }