Change download_from_google_storage.py to not run gsutil config when receiving a 403

Change download_from_google_storage.py to not run gsutil config when receiving a 403

When a developer runs download_from_google_storage, and they don't have a .boto
file, the tool automatically runs "gsutil config" to create one for them.
Unfortunately, a side consequence is that if a bot runs the script, and it has
a boto file that 403's, then it would run "gsutil config" which moves the .boto
to .boto.bak, and creates an empty .boto file.  This should not be the intended
action.

This CL changes so that "gsutil config" is not called, but instead just fails
with a message telling the dev to run that command.

TBR=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203824

[Ryan Tseng, 2013-06-04 03:20:31]

Submitting TBR to prevent any more .boto files from disappearing.

[Ryan Tseng, 2013-06-04 03:25:45]

Committed patchset #1 manually as r203824.

[cmp_google, 2013-06-04 05:08:05]

+iannucci for review, as well

[iannucci, 2013-06-04 05:15:15]

lgtm

https://codereview.chromium.org/16072023/diff/1/tests/download_from_google_st...
File tests/download_from_google_storage_unittests.py (right):

https://codereview.chromium.org/16072023/diff/1/tests/download_from_google_st...
tests/download_from_google_storage_unittests.py:85: 'checksum
010822c61d38d70ac23600bc955fccf5 (OK)')
why did this change? Is this the checksum of download_from_google_storage.py?

[Ryan Tseng, 2013-06-04 05:58:40]

On Mon, Jun 3, 2013 at 10:15 PM, <iannucci@chromium.org> wrote:

> lgtm
>
>
>
>
> https://codereview.chromium.**org/16072023/diff/1/tests/**
>
download_from_google_storage_**unittests.py<https://codereview.chromium.org/16072023/diff/1/tests/download_from_google_storage_unittests.py>
> File tests/download_from_google_**storage_unittests.py (right):
>
> https://codereview.chromium.**org/16072023/diff/1/tests/**
>
download_from_google_storage_**unittests.py#newcode85<https://codereview.chromium.org/16072023/diff/1/tests/download_from_google_storage_unittests.py#newcode85>
> tests/download_from_google_**storage_unittests.py:85: 'checksum
> 010822c61d38d70ac23600bc955fcc**f5 (OK)')
> why did this change? Is this the checksum of
> download_from_google_storage.**py?
>
Thats the checksum of the copy of gsutil in depot_tools.

>
>
https://codereview.chromium.**org/16072023/<https://codereview.chromium.org/1...
>

[Ryan Tseng, 2013-06-04 06:00:09]

To clarify, none of the gsutil files changed, but apparently it was
incorrect so I fixed it as to not leave it incorrect.


On Mon, Jun 3, 2013 at 10:58 PM, Ryan Tseng <hinoka@google.com> wrote:

>
>
>
> On Mon, Jun 3, 2013 at 10:15 PM, <iannucci@chromium.org> wrote:
>
>> lgtm
>>
>>
>>
>>
>> https://codereview.chromium.**org/16072023/diff/1/tests/**
>>
download_from_google_storage_**unittests.py<https://codereview.chromium.org/16072023/diff/1/tests/download_from_google_storage_unittests.py>
>> File tests/download_from_google_**storage_unittests.py (right):
>>
>> https://codereview.chromium.**org/16072023/diff/1/tests/**
>>
download_from_google_storage_**unittests.py#newcode85<https://codereview.chromium.org/16072023/diff/1/tests/download_from_google_storage_unittests.py#newcode85>
>> tests/download_from_google_**storage_unittests.py:85: 'checksum
>> 010822c61d38d70ac23600bc955fcc**f5 (OK)')
>> why did this change? Is this the checksum of
>> download_from_google_storage.**py?
>>
> Thats the checksum of the copy of gsutil in depot_tools.
>
>>
>>
https://codereview.chromium.**org/16072023/<https://codereview.chromium.org/1...
>>
>
>