Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: download_from_google_storage.py

Issue 16072023: Change download_from_google_storage.py to not run gsutil config when receiving a 403 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: download_from_google_storage.py
diff --git a/download_from_google_storage.py b/download_from_google_storage.py
index b1891755d326c4005f1a4de30357f2c8c05ebd3a..45e299c0b4c7018f344d25b79c2ff7e034b20d6f 100755
--- a/download_from_google_storage.py
+++ b/download_from_google_storage.py
@@ -81,9 +81,8 @@ def check_bucket_permissions(bucket, gsutil):
code, _, ls_err = gsutil.check_call('ls', base_url)
if code == 403:
- code, _, _ = gsutil.call('config')
- if code != 0:
- print >> sys.stderr, 'Error while authenticating to %s.' % base_url
+ print >> sys.stderr, 'Got error 403 while authenticating to %s.' % base_url
+ print >> sys.stderr, 'Try running "gsutil config".'
elif code == 404:
print >> sys.stderr, '%s not found.' % base_url
elif code != 0:
« no previous file with comments | « no previous file | tests/download_from_google_storage_unittests.py » ('j') | tests/download_from_google_storage_unittests.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698