Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1607153002: Fix order of files within APK when built using GN (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
pkotwicz, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, amineer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix order of files within APK when built using GN This was supposed to have been fixed by: https://codereview.chromium.org/1476203002 Bug it seems I got the order wrong. This also appears to fix the adb install failure on kitkat devices (INSTALL_FAILED_CONTAINER_ERROR). BUG=561862, 579252 Committed: https://crrev.com/a1b4b1c2f477cdfc2c49b874aa158494c867f502 Cr-Commit-Position: refs/heads/master@{#370326}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/android/gyp/apkbuilder.py View 3 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
agrieve
On 2016/01/20 02:38:58, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org ˙ ͜ʟ˙
4 years, 11 months ago (2016-01-20 02:39:18 UTC) #3
Yaron
On 2016/01/20 02:39:18, agrieve wrote: > On 2016/01/20 02:38:58, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years, 11 months ago (2016-01-20 03:05:21 UTC) #4
agrieve
On 2016/01/20 03:05:21, Yaron wrote: > On 2016/01/20 02:39:18, agrieve wrote: > > On 2016/01/20 ...
4 years, 11 months ago (2016-01-20 03:20:05 UTC) #5
Yaron
fair enough - lgtm
4 years, 11 months ago (2016-01-20 03:28:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607153002/1
4 years, 11 months ago (2016-01-20 03:29:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 05:55:39 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 05:57:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1b4b1c2f477cdfc2c49b874aa158494c867f502
Cr-Commit-Position: refs/heads/master@{#370326}

Powered by Google App Engine
This is Rietveld 408576698