GN: Make apkbuilder.py order files the same as GYP.

GN: Make apkbuilder.py order files the same as GYP.

BUG=561862
Committed: https://crrev.com/526655d5202eab917725825839cca76decdc64ed
Cr-Commit-Position: refs/heads/master@{#362032}

[agrieve, 2015-11-26 15:47:20]

Description was changed from

==========
GN: Make apkbuilder.py order files the same as GYP.

BUG=561862
==========

to

==========
GN: Make apkbuilder.py order files the same as GYP.

BUG=561862
==========

[agrieve, 2015-11-26 15:47:20]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2015-11-26 15:47:34]

On 2015/11/26 15:47:20, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

۰ • ●

[pkotwicz, 2015-11-26 20:47:45]

LGTM with nits

https://codereview.chromium.org/1476203002/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/1476203002/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:201: # 6. Java resources (order here might be
different from aapt. Oh well).
Nit: Comment that options.emma_device_jar should not be set for official builds.
So order here does not matter.

[agrieve, 2015-11-27 18:33:12]

https://codereview.chromium.org/1476203002/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/1476203002/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:201: # 6. Java resources (order here might be
different from aapt. Oh well).
On 2015/11/26 20:47:45, pkotwicz wrote:
> Nit: Comment that options.emma_device_jar should not be set for official
builds.
> So order here does not matter.

Done.

[agrieve, 2015-11-27 18:33:17]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-11-27 18:33:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/1476203002/#ps20001
(title: "improve comment")

[commit-bot: I haz the power, 2015-11-27 18:33:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476203002/20001

[commit-bot: I haz the power, 2015-11-27 19:59:42]

Description was changed from

==========
GN: Make apkbuilder.py order files the same as GYP.

BUG=561862
==========

to

==========
GN: Make apkbuilder.py order files the same as GYP.

BUG=561862
==========

[commit-bot: I haz the power, 2015-11-27 19:59:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-27 20:00:42]

Description was changed from

==========
GN: Make apkbuilder.py order files the same as GYP.

BUG=561862
==========

to

==========
GN: Make apkbuilder.py order files the same as GYP.

BUG=561862

Committed: https://crrev.com/526655d5202eab917725825839cca76decdc64ed
Cr-Commit-Position: refs/heads/master@{#362032}
==========

[commit-bot: I haz the power, 2015-11-27 20:00:43]

Patchset 2 (id:??) landed as
https://crrev.com/526655d5202eab917725825839cca76decdc64ed
Cr-Commit-Position: refs/heads/master@{#362032}