XFA: Unconditionally use static png_gt() in png.c

XFA: Unconditionally use static png_gt() in png.c

This is to avoid a compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/fd5f130ac81537c9066f5fb7998fdf08f501b40e

[Oliver Chang, 2016-01-19 20:39:34]

Description was changed from

==========
XFA: unconditionally use static png_gt in png.c to avoid compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

to

==========
XFA: Unconditionally use static png_gt in png.c to avoid compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

[Oliver Chang, 2016-01-19 20:40:27]

Description was changed from

==========
XFA: Unconditionally use static png_gt in png.c to avoid compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

to

==========
XFA: Unconditionally use static png_gt() in png.c to avoid compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

[Oliver Chang, 2016-01-19 20:40:46]

Description was changed from

==========
XFA: Unconditionally use static png_gt() in png.c to avoid compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

to

==========
XFA: Unconditionally use static png_gt() in png.c

This is to avoid a compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

[Oliver Chang, 2016-01-19 20:41:31]

Patchset #2 (id:20001) has been deleted

[Oliver Chang, 2016-01-19 20:42:28]

ptal

[Nico, 2016-01-19 21:46:23]

lgtm, thanks!

https://codereview.chromium.org/1607053003/diff/40001/third_party/libpng16/png.c
File third_party/libpng16/png.c (left):

https://codereview.chromium.org/1607053003/diff/40001/third_party/libpng16/pn...
third_party/libpng16/png.c:2467: #ifdef __GNUC__
other possible fixes:

* Change this line to `#if defined(__GNUC__) || defined(__clang__)` -- clang
defined __GNUC__ in gcc-compat mode, but not in clang-cl mode

* Just disable this warning for this target

[Oliver Chang, 2016-01-19 22:34:28]

Description was changed from

==========
XFA: Unconditionally use static png_gt() in png.c

This is to avoid a compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org
==========

to

==========
XFA: Unconditionally use static png_gt() in png.c

This is to avoid a compilation warning.

R=thakis@chromium.org
TBR=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/fd5f130ac81537c9066f5fb7998fdf08f501...
==========

[Oliver Chang, 2016-01-19 22:34:29]

Committed patchset #2 (id:40001) manually as
fd5f130ac81537c9066f5fb7998fdf08f501b40e (presubmit successful).

[Oliver Chang, 2016-01-19 22:35:47]

https://codereview.chromium.org/1607053003/diff/40001/third_party/libpng16/png.c
File third_party/libpng16/png.c (left):

https://codereview.chromium.org/1607053003/diff/40001/third_party/libpng16/pn...
third_party/libpng16/png.c:2467: #ifdef __GNUC__
On 2016/01/19 21:46:23, Nico wrote:
> other possible fixes:
> 
> * Change this line to `#if defined(__GNUC__) || defined(__clang__)` -- clang
> defined __GNUC__ in gcc-compat mode, but not in clang-cl mode
> 
> * Just disable this warning for this target

Hmm, I think this is still a valuable warning to keep in, in case legitimate
bugs are introduced in the future?