third_party/libpng16/png.c - Issue 1607053003: XFA: Unconditionally use static png_gt() in png.c

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libpng16/png.c

Issue 1607053003: XFA: Unconditionally use static png_gt() in png.c (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: README.pdfium Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libpng16/png.c

diff --git a/third_party/libpng16/png.c b/third_party/libpng16/png.c

index c183e3f8faf8f38cee95d8fb7b7edc9c2297cb64..1cf5271046863084329f4b45e1919e126d07e0a5 100644

--- a/third_party/libpng16/png.c

+++ b/third_party/libpng16/png.c

@@ -2464,7 +2464,8 @@ png_colorspace_set_rgb_coefficients(png_structrp png_ptr)

#endif /* COLORSPACE */

-#ifdef __GNUC__

Nico 2016/01/19 21:46:23 other possible fixes: * Change this line to `#if

Oliver Chang 2016/01/19 22:35:46 Hmm, I think this is still a valuable warning to k

+/* #ifdef __GNUC__ */

+#if 1

/* This exists solely to work round a warning from GNU C. */

static int /* PRIVATE */

png_gt(size_t a, size_t b)

« no previous file with comments | « third_party/libpng16/README.pdfium ('k') | no next file » | no next file with comments »