Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1606943002: A few more small changes to make GrAtlasTextBlob nearly self contained (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@cleanuptext16
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

A few more small changes to make GrAtlasTextBlob nearly self contained Note: There is still a bit of friendliness, but its going to require some creativity to deal with. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1606943002 Committed: https://skia.googlesource.com/skia/+/323c2ebe9e171d399c922f1efb5b6a2ca9d56b2e

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -211 lines) Patch
M src/gpu/batches/GrAtlasTextBatch.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.h View 4 chunks +213 lines, -182 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 1 2 chunks +17 lines, -6 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 5 chunks +7 lines, -14 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
joshualitt
This CL hides GrAtlasTextBlob's internals from GrAtlasTextContext and GrTextUtils. GrAtlasTextBatch and GrTextBlobCache have been made ...
4 years, 11 months ago (2016-01-19 16:06:19 UTC) #3
bsalomon
rubber stamp lgtm
4 years, 11 months ago (2016-01-19 17:08:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606943002/20001
4 years, 11 months ago (2016-01-20 14:37:23 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 14:48:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/323c2ebe9e171d399c922f1efb5b6a2ca9d56b2e

Powered by Google App Engine
This is Rietveld 408576698