Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 160663: Use a font size of 9pt in the tab titles. This is a bit (Closed)

Created:
11 years, 4 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Use a font size of 9pt in the tab titles. This is a bit bigger than before. This matches the font size used in Windows (the heights are the same), but on Linux, the text render a bit wider. BUG=17866

Patch Set 1 #

Patch Set 2 : shift #

Patch Set 3 : article #

Total comments: 1

Patch Set 4 : todo + bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 1 2 3 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tony
11 years, 4 months ago (2009-08-05 19:09:04 UTC) #1
Evan Martin
+estade, baseline man Would you mind including why we're doing this in the description? (something ...
11 years, 4 months ago (2009-08-05 19:12:15 UTC) #2
Evan Stade
http://codereview.chromium.org/160663/diff/1003/4 File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right): http://codereview.chromium.org/160663/diff/1003/4#newcode548 Line 548: int title_top = kTopPadding + (content_height - title_font_height_) ...
11 years, 4 months ago (2009-08-05 19:50:53 UTC) #3
tony
On 2009/08/05 19:50:53, Evan Stade wrote: > http://codereview.chromium.org/160663/diff/1003/4 > File chrome/browser/gtk/tabs/tab_renderer_gtk.cc (right): > > http://codereview.chromium.org/160663/diff/1003/4#newcode548 ...
11 years, 4 months ago (2009-08-05 20:14:24 UTC) #4
Evan Stade
dang, dunno why it is off. Either way is fine then, can you put a ...
11 years, 4 months ago (2009-08-05 20:28:19 UTC) #5
tony
11 years, 4 months ago (2009-08-05 20:34:08 UTC) #6
On 2009/08/05 20:28:19, Evan Stade wrote:
> dang, dunno why it is off. Either way is fine then, can you put a TODO for me
to
> figure out why the fudge is needed?

Done, and bug http://crbug.com/18555 filed.

Powered by Google App Engine
This is Rietveld 408576698