Chromium Code Reviews| Index: tools/gn/config_values.h |
| diff --git a/tools/gn/config_values.h b/tools/gn/config_values.h |
| index 823f1df9fc4b4a4f0359c8968a3d310e34790689..4a09ae3a80a1e8c5cfb6f5246c4c5e1252c46aa7 100644 |
| --- a/tools/gn/config_values.h |
| +++ b/tools/gn/config_values.h |
| @@ -29,6 +29,9 @@ class ConfigValues { |
| #define DIR_VALUES_ACCESSOR(name) \ |
| const std::vector<SourceDir>& name() const { return name##_; } \ |
| std::vector<SourceDir>& name() { return name##_; } |
| +#define SRC_VALUES_ACCESSOR(name) \ |
| + const std::vector<SourceFile>& name() const { return name##_; } \ |
|
brettw
2016/01/20 22:23:17
Putting this on config values seems wrong to me. N
sdefresne
2016/01/21 22:00:56
Done. Code is much cleaner. Thanks.
|
| + std::vector<SourceFile>& name() { return name##_; } |
| STRING_VALUES_ACCESSOR(asmflags) |
| STRING_VALUES_ACCESSOR(cflags) |
| @@ -40,10 +43,12 @@ class ConfigValues { |
| DIR_VALUES_ACCESSOR (include_dirs) |
| STRING_VALUES_ACCESSOR(ldflags) |
| DIR_VALUES_ACCESSOR (lib_dirs) |
| + SRC_VALUES_ACCESSOR (bundle_data) |
| // If you add a new one, be sure to update AppendValues(). |
| #undef STRING_VALUES_ACCESSOR |
| #undef DIR_VALUES_ACCESSOR |
| +#undef SRC_VALUES_ACCESSOR |
| const std::vector<LibFile>& libs() const { return libs_; } |
| std::vector<LibFile>& libs() { return libs_; } |
| @@ -76,6 +81,7 @@ class ConfigValues { |
| std::vector<std::string> ldflags_; |
| std::vector<SourceDir> lib_dirs_; |
| std::vector<LibFile> libs_; |
| + std::vector<SourceFile> bundle_data_; |
| // If you add a new one, be sure to update AppendValues(). |
| std::string precompiled_header_; |