Add support for Mac/iOS application bundles to GN tool.

tools/gn/config_values.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_GN_CONFIG_VALUES_H_
 #define TOOLS_GN_CONFIG_VALUES_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 11 matching lines @@
 
   // Appends the values from the given config to this one.
   void AppendValues(const ConfigValues& append);
 
 #define STRING_VALUES_ACCESSOR(name) \
     const std::vector<std::string>& name() const { return name##_; } \
     std::vector<std::string>& name() { return name##_; }
 #define DIR_VALUES_ACCESSOR(name) \
     const std::vector<SourceDir>& name() const { return name##_; } \
     std::vector<SourceDir>& name() { return name##_; }
+#define SRC_VALUES_ACCESSOR(name) \
+    const std::vector<SourceFile>& name() const { return name##_; } \

[brettw, 2016/01/20 22:23:17]

Putting this on config values seems wrong to me. No other source or data is on
here. Configs are really for settings that need to be applied to multiple
targets. I don't think that's the case here, and that bundle data is really
associated with a single target and propagated through the dependency tree.

If my understanding is correct, we should put the bundle data on the Target like
data is, and to collect the sources to it, iterate the dependency tree and
collect the files (as we do for data, see runtime_deps.cc).

[sdefresne, 2016/01/21 22:00:56]

Done. Code is much cleaner. Thanks.

+    std::vector<SourceFile>& name() { return name##_; }
 
   STRING_VALUES_ACCESSOR(asmflags)
   STRING_VALUES_ACCESSOR(cflags)
   STRING_VALUES_ACCESSOR(cflags_c)
   STRING_VALUES_ACCESSOR(cflags_cc)
   STRING_VALUES_ACCESSOR(cflags_objc)
   STRING_VALUES_ACCESSOR(cflags_objcc)
   STRING_VALUES_ACCESSOR(defines)
   DIR_VALUES_ACCESSOR   (include_dirs)
   STRING_VALUES_ACCESSOR(ldflags)
   DIR_VALUES_ACCESSOR   (lib_dirs)
+  SRC_VALUES_ACCESSOR   (bundle_data)
   // If you add a new one, be sure to update AppendValues().
 
 #undef STRING_VALUES_ACCESSOR
 #undef DIR_VALUES_ACCESSOR
+#undef SRC_VALUES_ACCESSOR
 
   const std::vector<LibFile>& libs() const { return libs_; }
   std::vector<LibFile>& libs() { return libs_; }
 
   bool has_precompiled_headers() const {
     return !precompiled_header_.empty() || !precompiled_source_.is_null();
   }
   const std::string& precompiled_header() const {
     return precompiled_header_;
   }
@@ skipping 12 matching lines @@
   std::vector<std::string> cflags_;
   std::vector<std::string> cflags_c_;
   std::vector<std::string> cflags_cc_;
   std::vector<std::string> cflags_objc_;
   std::vector<std::string> cflags_objcc_;
   std::vector<std::string> defines_;
   std::vector<SourceDir>   include_dirs_;
   std::vector<std::string> ldflags_;
   std::vector<SourceDir>   lib_dirs_;
   std::vector<LibFile>     libs_;
+  std::vector<SourceFile>  bundle_data_;
   // If you add a new one, be sure to update AppendValues().
 
   std::string precompiled_header_;
   SourceFile precompiled_source_;
 };
 
 #endif  // TOOLS_GN_CONFIG_VALUES_H_