Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: build/toolchain/mac/BUILD.gn

Issue 1606553002: Add support for Mac/iOS application bundles to GN tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: base_unittests builds and pass all tests with GN Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/toolchain/mac/BUILD.gn
diff --git a/build/toolchain/mac/BUILD.gn b/build/toolchain/mac/BUILD.gn
index 2666846c19303dfb370b1e08a961705b3c234584..ecd740654a9450870a0f2aacb7e2a0144861a303 100644
--- a/build/toolchain/mac/BUILD.gn
+++ b/build/toolchain/mac/BUILD.gn
@@ -231,6 +231,10 @@ template("mac_toolchain") {
command = copy_command
description = copy_description
}
+ tool("copy_bundle_data") {
+ command = "rm -rf {{output}} && ./gyp-mac-tool copy-bundle-resource {{source}} {{output}} True"
brettw 2016/01/20 22:23:17 My understanding is that the source will be a sing
sdefresne 2016/01/21 22:00:56 This is incorrect. This tool will be invoked for e
brettw 2016/01/25 21:06:08 I see, I see "rm -rf" and I assume the parameter i
sdefresne 2016/01/26 12:11:54 Replied on https://codereview.chromium.org/1611363
+ description = "COPY_BUNDLE_DATA {{source}} {{output}}"
+ }
toolchain_args() {
current_cpu = invoker.toolchain_cpu
« no previous file with comments | « build/config/ios/rules.gni ('k') | ios/web/shell/BUILD.gn » ('j') | tools/gn/config_values.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698