Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1606533002: Remove always-false null checks for getElementsByTagName(NS) (Closed)

Created:
4 years, 11 months ago by philipj_slow
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove always-false null checks for getElementsByTagName(NS) getElementsByTagNameNS is called from WebNode::getElementsByHTMLTagName, which in turn is only called with the static kLabel ("label"). getElementsByTagName is also called internally in getElementsByTagNameNS. Other than this, both are called from bindings. In no case is it possible for localName to be a null AtomicString, so these checks are not needed. Committed: https://crrev.com/43c8760bc6f96d7a8d4c4375d9186124e1c8dc0a Cr-Commit-Position: refs/heads/master@{#370616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606533002/1
4 years, 11 months ago (2016-01-18 15:28:06 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-18 17:05:13 UTC) #4
philipj_slow
PTAL. If you prefer I could add ASSERTs.
4 years, 11 months ago (2016-01-20 15:34:14 UTC) #7
tkent
lgtm
4 years, 11 months ago (2016-01-20 23:14:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606533002/1
4 years, 11 months ago (2016-01-20 23:15:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 04:12:47 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 04:14:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43c8760bc6f96d7a8d4c4375d9186124e1c8dc0a
Cr-Commit-Position: refs/heads/master@{#370616}

Powered by Google App Engine
This is Rietveld 408576698