Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1606533002: Remove always-false null checks for getElementsByTagName(NS) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp
diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
index 2ee1257276b57493dbe2713a342f4d9e6fd0b660..d9edc6db0fe24d1cb2055611e9a6d1e2a0799809 100644
--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp
+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp
@@ -1465,9 +1465,6 @@ void ContainerNode::invalidateNodeListCachesInAncestors(const QualifiedName* att
PassRefPtrWillBeRawPtr<TagCollection> ContainerNode::getElementsByTagName(const AtomicString& localName)
{
- if (localName.isNull())
- return nullptr;
-
if (document().isHTMLDocument())
return ensureCachedCollection<HTMLTagCollection>(HTMLTagCollectionType, localName);
return ensureCachedCollection<TagCollection>(TagCollectionType, localName);
@@ -1475,9 +1472,6 @@ PassRefPtrWillBeRawPtr<TagCollection> ContainerNode::getElementsByTagName(const
PassRefPtrWillBeRawPtr<TagCollection> ContainerNode::getElementsByTagNameNS(const AtomicString& namespaceURI, const AtomicString& localName)
{
- if (localName.isNull())
- return nullptr;
-
if (namespaceURI == starAtom)
return getElementsByTagName(localName);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698