Issue 160631: Don't show themes in extension config UI. This fixes various bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160631: Don't show themes in extension config UI. This fixes various bugs (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Glen Murphy

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Don't show themes in extension config UI. This fixes various bugs where the extension config UI doesn't work right with themes. This isn't ideal because users go to chrome://extensions/ expecting themes to be listed. If they aren't there, users might be confused. But I don't have an alternate solution. Also, this change removes the error listing from the top of chrome://extensions/. These errors are just getting noisy, I don't think they provide much value. BUG=13649, 18456 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22578

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -22 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -1 line	1 comment	Download
M	chrome/browser/extensions/extensions_ui.cc	View	1 chunk	+5 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View	2 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Glen Murphy

11 years, 4 months ago (2009-08-05 22:30:19 UTC) #2

Glen's head approves this CL, with a nit:

http://codereview.chromium.org/160631/diff/1/2
File chrome/browser/browser_resources.grd (right):

http://codereview.chromium.org/160631/diff/1/2#newcode3
Line 3: without changes to the corresponding grd file. aa1 -->
?

Expand Messages | Collapse Messages