Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1847)

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 160631: Don't show themes in extension config UI. This fixes various bugs (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_ui.cc
diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc
index 73714f5479bd890ed67dcee1dee9e15d92aa5a94..57cdae0ebcf252139e9b0c6b6bd9e8ba4c91bd27 100644
--- a/chrome/browser/extensions/extensions_ui.cc
+++ b/chrome/browser/extensions/extensions_ui.cc
@@ -89,21 +89,15 @@ void ExtensionsDOMHandler::HandleRequestExtensionsData(const Value* value) {
const ExtensionList* extensions = extensions_service_->extensions();
for (ExtensionList::const_iterator extension = extensions->begin();
extension != extensions->end(); ++extension) {
- extensions_list->Append(CreateExtensionDetailValue(
+ // Don't show the themes since this page's UI isn't really useful for
+ // themes.
+ if (!(*extension)->IsTheme()) {
+ extensions_list->Append(CreateExtensionDetailValue(
*extension, GetActivePagesForExtension((*extension)->id())));
+ }
}
results.Set(L"extensions", extensions_list);
- // Add any error log lines to the result structure.
- ListValue *errors_list = new ListValue();
- const std::vector<std::string>* errors =
- ExtensionErrorReporter::GetInstance()->GetErrors();
- for (std::vector<std::string>::const_iterator error = errors->begin();
- error != errors->end(); ++error) {
- errors_list->Append(Value::CreateStringValue(*error));
- }
- results.Set(L"errors", errors_list);
-
dom_ui_->CallJavascriptFunction(L"returnExtensionsData", results);
}

Powered by Google App Engine
This is Rietveld 408576698