Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 16063002: Revert 202305 "Destroy all Singletons and LazyInstances between ..." (Closed)

Created:
7 years, 7 months ago by Robert Sesek
Modified:
7 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202305 "Destroy all Singletons and LazyInstances between ..." > Destroy all Singletons and LazyInstances between each test. > > This modifies base::TestSuite to add a test listener that runs the AtExitManager > between each test. > > BUG=110594, 156433, 238654 > TEST=*unit*tests > R=apatrick@chromium.org, gspencer@chromium.org, phajdan.jr@chromium.org, pneubeck@chromium.org, rsleevi@chromium.org > > Review URL: https://codereview.chromium.org/8947021 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -44 lines) Patch
M trunk/src/base/test/test_suite.cc View 2 chunks +0 lines, -30 lines 0 comments Download
M trunk/src/chromeos/network/onc/onc_certificate_importer_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/crypto/nss_util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/gpu/command_buffer/service/shader_translator.cc View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Robert Sesek
7 years, 7 months ago (2013-05-25 19:04:42 UTC) #1
Robert Sesek
7 years, 7 months ago (2013-05-25 19:04:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r202312.

Powered by Google App Engine
This is Rietveld 408576698