Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1606053002: fix 'set but not used' GCC warning (Closed)

Created:
4 years, 11 months ago by Mostyn Bramley-Moore
Modified:
4 years, 11 months ago
Reviewers:
jonross, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix 'set but not used' GCC warning Followup to https://codereview.chromium.org/1586353004 which introduced a warning when building with GCC. BUG=557130 Committed: https://crrev.com/c2a45e81ad8468e8204fb7efcaa2b838334b0c52 Cr-Commit-Position: refs/heads/master@{#370203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/controls/menu/menu_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606053002/1
4 years, 11 months ago (2016-01-19 19:38:25 UTC) #2
Mostyn Bramley-Moore
@sky, jonross: PTAL at this tiny fixup after https://codereview.chromium.org/1586353004 Without this, GCC builds fail with ...
4 years, 11 months ago (2016-01-19 19:39:28 UTC) #4
jonross
On 2016/01/19 19:39:28, Mostyn Bramley-Moore wrote: > @sky, jonross: PTAL at this tiny fixup after ...
4 years, 11 months ago (2016-01-19 19:48:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-19 20:27:31 UTC) #7
sky
LGTM
4 years, 11 months ago (2016-01-19 22:07:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1606053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1606053002/1
4 years, 11 months ago (2016-01-19 22:09:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-19 22:16:51 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-19 22:18:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2a45e81ad8468e8204fb7efcaa2b838334b0c52
Cr-Commit-Position: refs/heads/master@{#370203}

Powered by Google App Engine
This is Rietveld 408576698