Update reposting of events from menus

Update reposting of events from menus

This change addresses a potential crash in MenuController::RepostEvent, along with a regression in touch event reposting on Chrome OS.

In MenuController::SetSelectionOnPointerDown the call of Cancel can lead to the deletion of the source of the event. RepostEvent can crash while attempting to transform the event location to screen coordinates. This change performs the transform before cancelling.

In MenuController::OnTouchEvent a call was added to RepostEvent. On Windows this eventually leads to the closing of the menu after capture is released. However this does not occur on Chrome OS, leading to the menu never closing. This change refactors out the Repost/Cancel logic from SetSelectionOnPointerDown into RepostEventAndCancel, providing one location to handle the reposting and shutdown logic differences of Windows and Chrome OS. SetSelectionOnPointerDown and OnTouchEvent now use this.

TEST=MenuControllerTest.AsynchronousRepostEvent, MenuControllerTest.AsynchronousTouchEventRepostEvent, as well as manual testing on a Chromebook to confirm touch regression has been fixed.
BUG=557130
Committed: https://crrev.com/580431e42ab952e84b32e9244acb252b1a76c575
Cr-Commit-Position: refs/heads/master@{#370143}

[jonross, 2016-01-15 16:20:30]

Patchset #1 (id:1) has been deleted

[jonross, 2016-01-15 16:21:37]

jonross@chromium.org changed reviewers:
+ ananta@chromium.org

[jonross, 2016-01-15 16:21:37]

Hi ananta@,

This change contains a follow up to your review:
https://codereview.chromium.org/1565013002/

PTAL

[jonross, 2016-01-15 16:22:11]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-01-15 16:22:11]

Hi sky,

Could you provide an owner's review of this change to MenuController?

Thanks,
Jon

[sky, 2016-01-19 16:35:03]

LGTM

[jonross, 2016-01-19 17:32:10]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-01-19 17:34:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1586353004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1586353004/20001

[commit-bot: I haz the power, 2016-01-19 18:20:03]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-01-19 18:21:20]

Description was changed from

==========
Update reposting of events from menus

This change addresses a potential crash in MenuController::RepostEvent, along
with a regression in touch event reposting on Chrome OS.

In MenuController::SetSelectionOnPointerDown the call of Cancel can lead to the
deletion of the source of the event. RepostEvent can crash while attempting to
transform the event location to screen coordinates. This change performs the
transform before cancelling.

In MenuController::OnTouchEvent a call was added to RepostEvent. On Windows this
eventually leads to the closing of the menu after capture is released. However
this does not occur on Chrome OS, leading to the menu never closing. This change
refactors out the Repost/Cancel logic from SetSelectionOnPointerDown into
RepostEventAndCancel, providing one location to handle the reposting and
shutdown logic differences of Windows and Chrome OS. SetSelectionOnPointerDown
and OnTouchEvent now use this.

TEST=MenuControllerTest.AsynchronousRepostEvent,
MenuControllerTest.AsynchronousTouchEventRepostEvent, as well as manual testing
on a Chromebook to confirm touch regression has been fixed.
BUG=557130
==========

to

==========
Update reposting of events from menus

This change addresses a potential crash in MenuController::RepostEvent, along
with a regression in touch event reposting on Chrome OS.

In MenuController::SetSelectionOnPointerDown the call of Cancel can lead to the
deletion of the source of the event. RepostEvent can crash while attempting to
transform the event location to screen coordinates. This change performs the
transform before cancelling.

In MenuController::OnTouchEvent a call was added to RepostEvent. On Windows this
eventually leads to the closing of the menu after capture is released. However
this does not occur on Chrome OS, leading to the menu never closing. This change
refactors out the Repost/Cancel logic from SetSelectionOnPointerDown into
RepostEventAndCancel, providing one location to handle the reposting and
shutdown logic differences of Windows and Chrome OS. SetSelectionOnPointerDown
and OnTouchEvent now use this.

TEST=MenuControllerTest.AsynchronousRepostEvent,
MenuControllerTest.AsynchronousTouchEventRepostEvent, as well as manual testing
on a Chromebook to confirm touch regression has been fixed.
BUG=557130

Committed: https://crrev.com/580431e42ab952e84b32e9244acb252b1a76c575
Cr-Commit-Position: refs/heads/master@{#370143}
==========

[commit-bot: I haz the power, 2016-01-19 18:21:21]

Patchset 1 (id:??) landed as
https://crrev.com/580431e42ab952e84b32e9244acb252b1a76c575
Cr-Commit-Position: refs/heads/master@{#370143}