Remove dismissForEachType() from SnackbarController

Remove dismissForEachType() from SnackbarController

dismissForEachType is only used by UndoBarPopupController to record
dismissal. Yet it is found out recently that this API is the reason why
total of dismisses does not equal to total of snackbar shows.

BUG=579347
Committed: https://crrev.com/40f30385a7fd945d11c2043eeaae8ef8b3f3337b
Cr-Commit-Position: refs/heads/master@{#370319}

[Ian Wen, 2016-01-20 00:53:14]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org

[Ian Wen, 2016-01-20 00:53:15]

PTAL

[Ian Wen, 2016-01-20 01:08:56]

ianwen@chromium.org changed reviewers:
+ isherman@chromium.org

[Ian Wen, 2016-01-20 01:08:56]

isherman@ could you PTAL the change in histograms.xml? Thanks!

[newt (away), 2016-01-20 01:23:48]

lgtm

https://codereview.chromium.org/1606043004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1606043004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:58:
* Callback triggered when user clicks on button at end of snackbar. This method
is only
I think we can simplify this comment. How about simply:

    "Called when the user clicks the action button on the snackbar."

The other parts of the comment don't add any value, in my opinion. *Of course*,
this method is only called for on the appropriate SnackbarController object;
that could be said of all methods everywhere :)

[Ilya Sherman, 2016-01-20 01:26:08]

histograms.xml lgtm

[Ian Wen, 2016-01-20 01:37:31]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-01-20 01:37:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1606043004/#ps60001
(title: "Fix comments")

[Ian Wen, 2016-01-20 01:37:38]

https://codereview.chromium.org/1606043004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1606043004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:58:
* Callback triggered when user clicks on button at end of snackbar. This method
is only
On 2016/01/20 01:23:48, newt wrote:
> I think we can simplify this comment. How about simply:
> 
>     "Called when the user clicks the action button on the snackbar."
> 
> The other parts of the comment don't add any value, in my opinion. *Of
course*,
> this method is only called for on the appropriate SnackbarController object;
> that could be said of all methods everywhere :)

Done.

[commit-bot: I haz the power, 2016-01-20 01:38:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1606043004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1606043004/60001

[commit-bot: I haz the power, 2016-01-20 05:19:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-20 05:20:35]

Description was changed from

==========
Remove dismissForEachType() from SnackbarController

dismissForEachType is only used by UndoBarPopupController to record
dismissal. Yet it is found out recently that this API is the reason why
total of dismisses does not equal to total of snackbar shows.

BUG=579347
==========

to

==========
Remove dismissForEachType() from SnackbarController

dismissForEachType is only used by UndoBarPopupController to record
dismissal. Yet it is found out recently that this API is the reason why
total of dismisses does not equal to total of snackbar shows.

BUG=579347

Committed: https://crrev.com/40f30385a7fd945d11c2043eeaae8ef8b3f3337b
Cr-Commit-Position: refs/heads/master@{#370319}
==========

[commit-bot: I haz the power, 2016-01-20 05:20:35]

Patchset 4 (id:??) landed as
https://crrev.com/40f30385a7fd945d11c2043eeaae8ef8b3f3337b
Cr-Commit-Position: refs/heads/master@{#370319}